Skip to content

Schedule commands in the current thread context #17143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nik9000 opened this issue Mar 16, 2016 · 1 comment · Fixed by #54187
Closed

Schedule commands in the current thread context #17143

nik9000 opened this issue Mar 16, 2016 · 1 comment · Fixed by #54187
Labels
:Core/Infra/Core Core issues without another label >enhancement help wanted adoptme

Comments

@nik9000
Copy link
Member

nik9000 commented Mar 16, 2016

Right now ThreadPool's schedule and scheduleWithFixedDelay schedule a command to run without any thread context. As of #17077 it will be possible to intentionally schedule a command in the current thread context. We should make that behavior the default behavior.
@nik9000 nik9000 added the :Core/Infra/Core Core issues without another label label Mar 16, 2016
@nik9000 nik9000 mentioned this issue Mar 16, 2016
Closed
@clintongormley clintongormley added >enhancement help wanted adoptme :Internal and removed :Core/Infra/Core Core issues without another label labels Mar 17, 2016
@colings86 colings86 added the :Core/Infra/Core Core issues without another label label Apr 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

ywelsch added a commit to ywelsch/elasticsearch that referenced this issue Mar 25, 2020
@ywelsch
Schedule commands in current thread context
f31635f 
Closes elastic#17143
@ywelsch ywelsch mentioned this issue Mar 25, 2020
Merged
ywelsch added a commit that referenced this issue Mar 26, 2020
@ywelsch
Schedule commands in current thread context (#54187)
0a34b71 
Changes ThreadPool's schedule method to run the schedule task in the context of the thread
that scheduled the task.

This is the more sensible default for this method, and eliminates a range of bugs where the
current thread context is mistakenly dropped.

Closes #17143
ywelsch added a commit that referenced this issue Mar 26, 2020
@ywelsch
Schedule commands in current thread context (#54187)
1ba6783 
Changes ThreadPool's schedule method to run the schedule task in the context of the thread
that scheduled the task.

This is the more sensible default for this method, and eliminates a range of bugs where the
current thread context is mistakenly dropped.

Closes #17143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label >enhancement help wanted adoptme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Schedule commands in current thread context ywelsch/elasticsearch
4 participants
@clintongormley @nik9000 @colings86 @elasticmachine