REST client pom.xml has runtime dependencies

[dadoonet]

With alpha5-SNAPSHOT, here is an extract of the generated pom.xml. See https://oss.sonatype.org/content/repositories/snapshots/org/elasticsearch/client/rest/5.0.0-alpha5-SNAPSHOT/rest-5.0.0-alpha5-20160805.100826-168.pom

<dependency>
  <groupId>org.apache.httpcomponents</groupId>
  <artifactId>httpcore</artifactId>
  <version>4.4.5</version>
  <scope>runtime</scope>
</dependency>
<dependency>
  <groupId>org.apache.httpcomponents</groupId>
  <artifactId>httpasyncclient</artifactId>
  <version>4.1.2</version>
  <scope>runtime</scope>
</dependency>

Which basically means that you can't use OOTB the apache classes:

RestClient restClient = RestClient.builder(
        new HttpHost("http", "localhost", 9200),
        new HttpHost("http", "localhost", 9201)).build();

This won't compile.

Note that it was working well with alpha4. I did not try a "final" released version of alpha5 though.

[dadoonet]

The workaround for now is to add in the project which uses a REST client:

<dependency>
    <groupId>org.apache.httpcomponents</groupId>
    <artifactId>httpcore</artifactId>
    <version>4.4.5</version>
    <scope>compile</scope>
</dependency>
<dependency>
    <groupId>org.apache.httpcomponents</groupId>
    <artifactId>httpasyncclient</artifactId>
    <version>4.1.2</version>
    <scope>compile</scope>
</dependency>
<dependency>
    <groupId>org.apache.httpcomponents</groupId>
    <artifactId>httpclient</artifactId>
    <version>4.1.2</version>
    <scope>compile</scope>
</dependency>

[nik9000]

Hmm - I think it'd be much more friendly to call them compile dependencies. We mostly want them to be. If the user really wants them to be runtime dependencies they can override the scope in their pom.

[javanna]

I have no idea where this runtime thing comes from, they are declared compile in our build.gradle. https://github.com/elastic/elasticsearch/blob/master/client/rest/build.gradle#L34

[nik9000]

I expect it is a pom generation thing.

[javanna]

@rjernst do you know where this may come from? let me know if I can help.

[rjernst]

This is an issue with the maven-publish plugin in gradle, which the unified release uses. In alpha5, we generated the poms for the client jars using the new mechanism, while the old jar poms were still built using the maven plugin.

I opened a PR to fix: #19876