Skip to content

InstallPluginCommandTests.testPluginsDirMissing fails on 5.x branch #24693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimczi opened this issue May 15, 2017 · 1 comment
Closed

InstallPluginCommandTests.testPluginsDirMissing fails on 5.x branch #24693

jimczi opened this issue May 15, 2017 · 1 comment
Assignees
Labels
:Core/Infra/Plugins Plugin API and infrastructure >test Issues or PRs that are addressing/adding tests

Comments

@jimczi
Copy link
Contributor

jimczi commented May 15, 2017

We had several unnoticed build failure on 5.x:
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+5.x+multijob-intake/1173/console
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+5.x+multijob-intake/1195/console
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+5.x+multijob-intake/1201/console

The test failures are always the same:

Tests with failures:
  - org.elasticsearch.plugins.InstallPluginCommandTests.testPluginsDirMissing {p0=sun.nio.fs.LinuxFileSystem@6b67034 p1=org.elasticsearch.plugins.InstallPluginCommandTests$$Lambda$116/827084938@16267862}
  - org.elasticsearch.plugins.InstallPluginCommandTests.testPluginsDirMissing {p0=com.google.common.jimfs.JimfsFileSystem@453da22c p1=org.elasticsearch.plugins.InstallPluginCommandTests$1Parameter$$Lambda$115/1579526446@71248c21}
  - org.elasticsearch.plugins.InstallPluginCommandTests.testPluginsDirMissing {p0=com.google.common.jimfs.JimfsFileSystem@442675e1 p1=org.elasticsearch.plugins.InstallPluginCommandTests$1Parameter$$Lambda$115/1579526446@6166e06f}
  - org.elasticsearch.plugins.InstallPluginCommandTests.testPluginsDirMissing {p0=com.google.common.jimfs.JimfsFileSystem@49e202ad p1=org.elasticsearch.plugins.InstallPluginCommandTests$1Parameter$$Lambda$115/1579526446@1c72da34}

... and the build also fail to send the email notice.

@jimczi jimczi added :Core/Infra/Plugins Plugin API and infrastructure >test Issues or PRs that are addressing/adding tests labels May 15, 2017
@rjernst
Copy link
Member

rjernst commented May 16, 2017

This was due to a broken backport of removing plugin dir leniency, but now I'm not sure why I was backporting that in the first place, so I have reverted the backport.

See #24173

@rjernst rjernst closed this as completed May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Plugins Plugin API and infrastructure >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

No branches or pull requests

3 participants