Skip to content

[CI] InternalExtendedStatsTests.testReduceRandom fails #24931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tlrx opened this issue May 29, 2017 · 1 comment
Closed

[CI] InternalExtendedStatsTests.testReduceRandom fails #24931

tlrx opened this issue May 29, 2017 · 1 comment
Assignees
Labels
:Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI v6.0.0-alpha2

Comments

@tlrx
Copy link
Member

tlrx commented May 29, 2017

InternalExtendedStatsTests.testReduceRandom fails with the following error:

   [junit4] <JUnit4> says नमस्ते! Master seed: BB928DDDA878E679
==> Test Info: seed=BB928DDDA878E679; jvm=1; suite=1
Suite: org.elasticsearch.search.aggregations.metrics.InternalExtendedStatsTests
  1> [2017-05-29T10:16:42,930][WARN ][o.e.b.JNANatives         ] Unable to lock JVM Memory: error=12, reason=Ne peut allouer de la mémoire
  1> [2017-05-29T10:16:42,933][WARN ][o.e.b.JNANatives         ] This can result in part of the JVM being swapped out.
  1> [2017-05-29T10:16:42,933][WARN ][o.e.b.JNANatives         ] Increase RLIMIT_MEMLOCK, soft limit: 65536, hard limit: 65536
  1> [2017-05-29T10:16:42,933][WARN ][o.e.b.JNANatives         ] These can be adjusted by modifying /etc/security/limits.conf, for example: 
  1>    # allow user 'tanguy' mlockall
  1>    tanguy soft memlock unlimited
  1>    tanguy hard memlock unlimited
  1> [2017-05-29T10:16:42,934][WARN ][o.e.b.JNANatives         ] If you are logged in interactively, you will have to re-login for the new limits to take effect.
  1> [2017-05-29T04:16:43,823][INFO ][o.e.s.a.m.InternalExtendedStatsTests] [testReduceRandom]: before test
  1> [2017-05-29T04:16:43,891][INFO ][o.e.s.a.m.InternalExtendedStatsTests] [testReduceRandom]: after test
  2> REPRODUCE WITH: gradle :core:test -Dtests.seed=BB928DDDA878E679 -Dtests.class=org.elasticsearch.search.aggregations.metrics.InternalExtendedStatsTests -Dtests.method="testReduceRandom" -Dtests.security.manager=true -Dtests.jvm.argline="-XX:-UseConcMarkSweepGC -XX:+UseG1GC" -Dtests.locale=th -Dtests.timezone=America/Manaus
FAILURE 0.53s | InternalExtendedStatsTests.testReduceRandom <<< FAILURES!
   > Throwable #1: java.lang.AssertionError: expected:<8.915190858759545E7> but was:<8.915190858759534E7>
   >    at __randomizedtesting.SeedInfo.seed([BB928DDDA878E679:7BAF21CC8E257F2F]:0)
   >    at org.elasticsearch.search.aggregations.metrics.InternalExtendedStatsTests.assertReduced(InternalExtendedStatsTests.java:85)
   >    at org.elasticsearch.search.aggregations.metrics.InternalExtendedStatsTests.assertReduced(InternalExtendedStatsTests.java:34)
   >    at org.elasticsearch.test.InternalAggregationTestCase.testReduceRandom(InternalAggregationTestCase.java:245)
   >    at java.lang.Thread.run(Thread.java:745)
  2> NOTE: leaving temporary files on disk at: /home/tanguy/Github/elasticsearch/core/build/testrun/test/J0/temp/org.elasticsearch.search.aggregations.metrics.InternalExtendedStatsTests_BB928DDDA878E679-001
  2> NOTE: test params are: codec=Asserting(Lucene70): {}, docValues:{}, maxPointsInLeafNode=1948, maxMBSortInHeap=7.81230414099695, sim=RandomSimilarity(queryNorm=true): {}, locale=th, timezone=America/Manaus
  2> NOTE: Linux 4.4.0-78-generic amd64/Oracle Corporation 1.8.0_121 (64-bit)/cpus=8,threads=1,free=497547272,total=536870912
  2> NOTE: All tests run in this JVM: [InternalExtendedStatsTests]
Completed [1/1] in 1.40s, 1 test, 1 failure <<< FAILURES!

Tests with failures:
  - org.elasticsearch.search.aggregations.metrics.InternalExtendedStatsTests.testReduceRandom

The failure can be reproduced using:

gradle :core:test -Dtests.seed=BB928DDDA878E679 -Dtests.class=org.elasticsearch.search.aggregations.metrics.InternalExtendedStatsTests -Dtests.method="testReduceRandom" -Dtests.security.manager=true -Dtests.jvm.argline="-XX:-UseConcMarkSweepGC -XX:+UseG1GC" -Dtests.locale=th -Dtests.timezone=America/Manaus

It failed today on CI, see https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+g1gc/2981/console

@tlrx tlrx added :Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests v6.0.0 labels May 29, 2017
cbuescher added a commit to cbuescher/elasticsearch that referenced this issue May 29, 2017
The order in which double values are added in Java can give different results,
so in testing the sum and sumOfSquares we need to allow some delta for testing
equality. The difference can be larger for large sum values, so we should
account for this by making the delta in the assertion depend on the values
magnitude.

Closes elastic#24931
@tlrx tlrx added the >test-failure Triaged test failures from CI label May 29, 2017
cbuescher added a commit that referenced this issue May 29, 2017
The order in which double values are added in Java can give different results,
so in testing the sum and sumOfSquares we need to allow some delta for testing
equality. The difference can be larger for large sum values, so we should
account for this by making the delta in the assertion depend on the values
magnitude.

Closes #24931
@talevy
Copy link
Contributor

talevy commented May 10, 2018

This popped up again on current master:

reproduce with:

./gradlew :server:test -Dtests.seed=97B9AEB9875197B5 -Dtests.class=org.elasticsearch.search.aggregations.metrics.InternalExtendedStatsTests -Dtests.method="testReduceRandom" -Dtests.security.manager=true -Dtests.locale=de-CH -Dtests.timezone=Europe/Sofia
FAILURE 0.03s J2 | InternalExtendedStatsTests.testReduceRandom <<< FAILURES!
   > Throwable #1: java.lang.AssertionError: expected:<321.2197163576493> but was:<321.2197163657984>
   > 	at __randomizedtesting.SeedInfo.seed([97B9AEB9875197B5:578402A8A10C0EE3]:0)
   > 	at org.elasticsearch.search.aggregations.metrics.InternalExtendedStatsTests.assertReduced(InternalExtendedStatsTests.java:87)
   > 	at org.elasticsearch.search.aggregations.metrics.InternalExtendedStatsTests.assertReduced(InternalExtendedStatsTests.java:37)
   > 	at org.elasticsearch.test.InternalAggregationTestCase.testReduceRandom(InternalAggregationTestCase.java:262)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >test Issues or PRs that are addressing/adding tests >test-failure Triaged test failures from CI v6.0.0-alpha2
Projects
None yet
Development

No branches or pull requests

4 participants