Skip to content

RestClientMultipleHostsIntegTests testNodeSelector fails on windows #31457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albertzaharovits opened this issue Jun 20, 2018 · 2 comments
Closed
Assignees
Labels
:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >test-failure Triaged test failures from CI

Comments

@albertzaharovits
Copy link
Contributor

There's a few of LL client failures, all of them on 6.x and windows:

java.lang.AssertionError: expected:<Connection refused> but was:<null>
	at __randomizedtesting.SeedInfo.seed([429EEC8C470749C5:26A699538C5AFAE7]:0)
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:144)
	at org.elasticsearch.client.RestClientMultipleHostsIntegTests.testNodeSelector(RestClientMultipleHostsIntegTests.java:217)
	....

that @nik9000 's commit 045f76d should have fixed this, but does it really? The message is null and not different. But the fix does appear to have worked on master yet not 6.x .

6.x failures:
https://groups.google.com/a/elastic.co/forum/#!searchin/build-elasticsearch/testNodeSelector|sort:date/build-elasticsearch/pIw1GjQIYAo/yf1OwCTgBAAJ
https://groups.google.com/a/elastic.co/forum/#!searchin/build-elasticsearch/testNodeSelector|sort:date/build-elasticsearch/BplpN0Ln0O4/jRVETj-TBQAJ
https://groups.google.com/a/elastic.co/forum/#!searchin/build-elasticsearch/testNodeSelector|sort:date/build-elasticsearch/45F3X_52Hd8/IPUoGGsdBQAJ

All of them tripping the same assertion about the connection error message.

@albertzaharovits albertzaharovits added >test-failure Triaged test failures from CI :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch labels Jun 20, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@nik9000
Copy link
Member

nik9000 commented Jun 20, 2018

Oh man! I thought I had fixed it..... Grumble Windows, grumble.

nik9000 added a commit that referenced this issue Jun 21, 2018
Windows doesn't provide consistent exception messages when it can't
connect so skip the exception message assertion on windows.

Closes #31457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >test-failure Triaged test failures from CI
Projects
None yet
Development

No branches or pull requests

3 participants