Skip to content

a little error about SearchType #32631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kkewwei opened this issue Aug 5, 2018 · 3 comments
Closed

a little error about SearchType #32631

kkewwei opened this issue Aug 5, 2018 · 3 comments
Labels
good first issue low hanging fruit help wanted adoptme :Search/Search Search-related issues that do not fall into other categories

Comments

@kkewwei
Copy link
Contributor

kkewwei commented Aug 5, 2018

elasticsearch/core/src/main/java/org/elasticsearch/action/search/TransportSearchAction.java

Line 287 in b727a60

searchRequest.searchType(QUERY_THEN_FETCH);

when it comes to one shard , here should be “QUERY_AND_FETCH”, not QUERY_THEN_FETCH.
@dnhatn
Copy link
Member

dnhatn commented Aug 5, 2018

@kkewwei Thanks for reporting this. QUERY_AND_FETCH was deprecated in 5.x, but I think we need to adjust the comment here.

@dnhatn dnhatn added the :Search/Search Search-related issues that do not fall into other categories label Aug 5, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@dnhatn dnhatn added help wanted adoptme good first issue low hanging fruit labels Aug 5, 2018
@javanna
Copy link
Member

javanna commented Aug 16, 2018

Check out #22996 and #28098 where this was changed. We moved the optimization for the single shard case to SearchService. I think what we have now is fine.

@javanna javanna closed this as completed Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue low hanging fruit help wanted adoptme :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@javanna @dnhatn @elasticmachine @kkewwei