[docs] Fix typoes in comment in source code #28098
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
@aeroastro thanks for the changes, I agree with all of them but one where I left a comment. Can you update, then I will merge this.
| @@ -963,7 +963,7 @@ public boolean canMatch(ShardSearchRequest request) throws IOException { | |||
| } | |||
|
|
|||
| /** | |||
| * Returns true iff the given search source builder can be early terminated by rewriting to a match none query. Or in other words | |||
| * Returns true if the given search source builder can be early terminated by rewriting to a match none query. Or in other words | |||
There was a problem hiding this comment.
I think iff is intended here, meaning "if and only if" here (https://en.wikipedia.org/wiki/If_and_only_if), I'd leave this as is.
|
Thank you for your review. |
There was a problem hiding this comment.
@aeroastro thanks, looks like instead of changing back you changed another occurance of "if". Left a comment, can you correct this please?
| @@ -963,8 +963,8 @@ public boolean canMatch(ShardSearchRequest request) throws IOException { | |||
| } | |||
|
|
|||
| /** | |||
| * Returns true iff the given search source builder can be early terminated by rewriting to a match none query. Or in other words | |||
| * if the execution of a the search request can be early terminated without executing it. This is for instance not possible if | |||
There was a problem hiding this comment.
Looks like you just changed both the first occurance of "iff" and the later "if" to the other version. Could you just change them back?
|
Sorry about that. |
* master: Fix Gradle wrapper usage on Windows when building BWC (elastic#28146) [Docs] Fix some typos in comments (elastic#28098)
|
Thank you 🐱 |
* master: (27 commits) Declare empty package dirs as output dirs Consistent updates of IndexShardSnapshotStatus (elastic#28130) Fix Gradle wrapper usage on Windows when building BWC (elastic#28146) [Docs] Fix some typos in comments (elastic#28098) Use Gradle wrapper when building BWC Painless: Add a simple cache for whitelist methods and fields. (elastic#28142) Fix upgrading indices which use a custom similarity plugin. (elastic#26985) Fix Licenses values for CDDL and Custom URL (elastic#27999) Cleanup TcpChannelFactory and remove classes (elastic#28102) Fix expected plugins test for transport-nio [Docs] Fix Date Math example descriptions (elastic#28125) Fail rollover if duplicated alias found in template (elastic#28110) Avoid concurrent snapshot finalizations when deleting an INIT snapshot (elastic#28078) Deprecate `isShardsAcked()` in favour of `isShardsAcknowledged()` (elastic#27819) [TEST] Wait for replicas to be allocated before shrinking Use the underlying connection version for CCS connections (elastic#28093) test: do not use asn fields Test: Add assumeFalse for test that cannot pass on windows Clarify reproduce info on Windows Remove out-of-date projectile file ...
While reading some code, I have found out some typoes.