Skip to content

SQL: incorrect artifactId inside the JDBC Maven pom #34399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
astefan opened this issue Oct 11, 2018 · 2 comments · Fixed by #34478
Closed

SQL: incorrect artifactId inside the JDBC Maven pom #34399

astefan opened this issue Oct 11, 2018 · 2 comments · Fixed by #34478
Labels
:Analytics/SQL SQL querying >bug

Comments

@astefan
Copy link
Contributor

astefan commented Oct 11, 2018

At the moment (6.4.2), we state in the documentation that the JDBC jar has the artifactId as x-pack-sql-jdbc, but the pom itself is incorrect with respect to the artifactId:

  <groupId>org.elasticsearch.plugin</groupId>
  <artifactId>jdbc</artifactId>
  <version>6.4.2</version>
  <packaging>pom</packaging>
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@astefan
Copy link
Contributor Author

astefan commented Oct 11, 2018

@nik9000 if you could have a look at this one, I would appreciate it.

nik9000 added a commit to nik9000/elasticsearch that referenced this issue Oct 15, 2018
@nik9000
JDBC: Fix artifactId in pom
e36006a 
We're publishing jdbc into our maven repo as though its artifactId is
`x-pack-sql-jdbc` but the pom listed the artifactId as `jdbc`. This
fixes the pom to line up with where we're publishing the artifact.

Closes elastic#34399
@nik9000 nik9000 mentioned this issue Oct 15, 2018
Merged
nik9000 added a commit that referenced this issue Oct 16, 2018
@nik9000
JDBC: Fix artifactId in pom (#34478)
540dfcf 
We're publishing jdbc into our maven repo as though its artifactId is
`x-pack-sql-jdbc` but the pom listed the artifactId as `jdbc`. This
fixes the pom to line up with where we're publishing the artifact.

Closes #34399
nik9000 added a commit that referenced this issue Oct 16, 2018
@nik9000
JDBC: Fix artifactId in pom (#34478)
8079e2f 
We're publishing jdbc into our maven repo as though its artifactId is
`x-pack-sql-jdbc` but the pom listed the artifactId as `jdbc`. This
fixes the pom to line up with where we're publishing the artifact.

Closes #34399
kcm pushed a commit that referenced this issue Oct 30, 2018
@nik9000 @kcm
JDBC: Fix artifactId in pom (#34478)
3867764 
We're publishing jdbc into our maven repo as though its artifactId is
`x-pack-sql-jdbc` but the pom listed the artifactId as `jdbc`. This
fixes the pom to line up with where we're publishing the artifact.

Closes #34399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JDBC: Fix artifactId in pom nik9000/elasticsearch
2 participants
@astefan @elasticmachine