Skip to content

RollupIndexerIndexingTests#testRandomizedDateHisto fails with assertion error. #34762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jtibshirani opened this issue Oct 23, 2018 · 4 comments · Fixed by #38753
Closed

RollupIndexerIndexingTests#testRandomizedDateHisto fails with assertion error. #34762

jtibshirani opened this issue Oct 23, 2018 · 4 comments · Fixed by #38753
Assignees
@polyfractal
Labels
:StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data >test-failure Triaged test failures from CI

Comments

@jtibshirani
Copy link
Contributor

jtibshirani commented Oct 23, 2018 •
edited
Loading

The failure reliably reproduces for me locally on master and 6.x. We've also seen CI failures on 6.4 (that might require a different set of parameters to reproduce).

Link to the build: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.x+multijob-darwin-compatibility/8/console

Command to reproduce:

 ./gradlew :x-pack:plugin:rollup:test \
  -Dtests.seed=B8C2D1D7B200C9BB \
  -Dtests.class=org.elasticsearch.xpack.rollup.job.RollupIndexerIndexingTests \
  -Dtests.method="testRandomizedDateHisto" \
  -Dtests.security.manager=true \
  -Dtests.locale=fr-CA \
  -Dtests.timezone=Asia/Anadyr \
  -Dcompiler.java=11 \
  -Druntime.java=8

Relevant excerpt from the logs:

FAILURE 2.72s | RollupIndexerIndexingTests.testRandomizedDateHisto <<< FAILURES!
   > Throwable #1: java.lang.AssertionError: 
   > Expected: a value greater than <0>
   >      but: <0> was equal to <0>
   >    at __randomizedtesting.SeedInfo.seed([B8C2D1D7B200C9BB:56314A37A321B66]:0)
   >    at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
   >    at org.elasticsearch.xpack.rollup.job.RollupIndexerIndexingTests.lambda$testRandomizedDateHisto$6(RollupIndexerIndexingTests.java:443)
   >    at org.elasticsearch.xpack.rollup.job.RollupIndexerIndexingTests.executeTestCase(RollupIndexerIndexingTests.java:499)
   >    at org.elasticsearch.xpack.rollup.job.RollupIndexerIndexingTests.testRandomizedDateHisto(RollupIndexerIndexingTests.java:442)
   >    at java.lang.Thread.run(Thread.java:748)
@jtibshirani jtibshirani added >test-failure Triaged test failures from CI :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data labels Oct 23, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@polyfractal
Copy link
Contributor

Ah, I see it. The random timestamps were landing too close to the current time, so an unlucky rollup interval would round such that the doc isn't included and the test fails.

Will push a fix to make sure the test docs are always within the search boundary.

polyfractal added a commit that referenced this issue Oct 23, 2018
@polyfractal
[TEST] Ensure random timestamps are within search boundary
368c6f2 
The random timestamps were landing too close to the current time,
so an unlucky rollup interval would round such that the doc wasn't
included in the search range (and thus not "rolled up") which
would then fail the test.

The fix is to make sure the timestamp of all docs is sufficiently behind
'now' that the possible rounding intervals will always include them.

Unmutes testRandomizedDateHisto, closes #34762
@jtibshirani
Copy link
Contributor Author

Forgot to comment earlier -- I muted the test in 90fd15b.

@polyfractal
Copy link
Contributor

This should be fixed... I just forgot to close the issue :)

polyfractal added a commit to polyfractal/elasticsearch that referenced this issue Feb 11, 2019
@polyfractal
Ensure random timestamps are within search boundary
7e6c0c2 
The random timestamps were landing too close to the current time,
so an unlucky rollup interval would round such that the doc wasn't
included in the search range (and thus not "rolled up") which
would then fail the test.

The fix is to make sure the timestamp of all docs is sufficiently behind
'now' that the possible rounding intervals will always include them.

Unmutes testRandomizedDateHisto, closes elastic#34762

"Forward-port" of 368c6f2 (wasn't
merged into master for some reason)
@polyfractal polyfractal mentioned this issue Feb 11, 2019
Merged
polyfractal added a commit that referenced this issue Feb 15, 2019
@polyfractal
Ensure random timestamps are within search boundary (#38753)
061c1fe 
The random timestamps were landing too close to the current time,
so an unlucky rollup interval would round such that the doc wasn't
included in the search range (and thus not "rolled up") which
would then fail the test.

The fix is to make sure the timestamp of all docs is sufficiently behind
'now' that the possible rounding intervals will always include them.

Unmutes testRandomizedDateHisto, closes #34762

"Forward-port" of 368c6f2 (wasn't
merged into master for some reason)
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Oct 9, 2019
@polyfractal
Ensure random timestamps are within search boundary (elastic#38753)
0d0c6e4 
The random timestamps were landing too close to the current time,
so an unlucky rollup interval would round such that the doc wasn't
included in the search range (and thus not "rolled up") which
would then fail the test.

The fix is to make sure the timestamp of all docs is sufficiently behind
'now' that the possible rounding intervals will always include them.

Unmutes testRandomizedDateHisto, closes elastic#34762

"Forward-port" of 368c6f2 (wasn't
merged into master for some reason)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@polyfractal polyfractal

Labels
:StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure random test timestamps are within search boundary polyfractal/elasticsearch
3 participants
@polyfractal @jtibshirani @elasticmachine