Skip to content

Support rest_total_hits_as_int in watcher #36008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jimczi opened this issue Nov 28, 2018 · 2 comments
Closed

Support rest_total_hits_as_int in watcher #36008

jimczi opened this issue Nov 28, 2018 · 2 comments
Labels
blocker :Data Management/Watcher :Search/Search Search-related issues that do not fall into other categories >upgrade v7.0.0-beta1

Comments

@jimczi
Copy link
Contributor

jimczi commented Nov 28, 2018

We introduced a new parameter to control how the total hits in the search response should be rendered (#35848). This parameter is not exposed in the search watcher input so the existing watch that extracts the total hits in 6x will not be compatible with v7. We should expose this parameter in order to help users to migrate their watch in v7.
@jimczi jimczi added blocker :Search/Search Search-related issues that do not fall into other categories labels Nov 28, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@jimczi jimczi mentioned this issue Nov 28, 2018
Merged
jimczi added a commit to jimczi/elasticsearch that referenced this issue Nov 29, 2018
@jimczi
Add support for rest_total_hits_as_int in watcher
50734da 
This change adds the support for rest_total_hits_as_int
in the watcher search inputs. Setting this parameter in the request
will transform the search response to contain the total hits as
a number (instead of an object).
Note that this parameter is currently a noop since elastic#35849 is not
merged.

Closes elastic#36008
@jimczi jimczi mentioned this issue Nov 29, 2018
Merged
@spinscale spinscale mentioned this issue Nov 30, 2018
Closed
jimczi added a commit that referenced this issue Nov 30, 2018
@jimczi
Add support for rest_total_hits_as_int in watcher (#36035)
e179fd1 
This change adds the support for rest_total_hits_as_int
in the watcher search inputs. Setting this parameter in the request
will transform the search response to contain the total hits as
a number (instead of an object).
Note that this parameter is currently a noop since #35849 is not
merged.

Closes #36008
jimczi added a commit that referenced this issue Nov 30, 2018
@jimczi
Add support for rest_total_hits_as_int in watcher (#36035)
4b482f2 
This change adds the support for rest_total_hits_as_int
in the watcher search inputs. Setting this parameter in the request
will transform the search response to contain the total hits as
a number (instead of an object).
Note that this parameter is currently a noop since #35849 is not
merged.

Closes #36008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocker :Data Management/Watcher :Search/Search Search-related issues that do not fall into other categories >upgrade v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colings86 @elasticmachine @jimczi