Skip to content

Rename feature_vector to feature_map? #36723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jpountz opened this issue Dec 17, 2018 · 3 comments
Closed

Rename feature_vector to feature_map? #36723

jpountz opened this issue Dec 17, 2018 · 3 comments
Assignees
@mayya-sharipova
Labels
>non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@jpountz
Copy link
Contributor

jpountz commented Dec 17, 2018

With the new vector field (#33022), there is concern that users are going to be confused with dense_vector/sparse_vector on the one hand and feature_vector on the other hand, which share similar names even though they have nothing in common.

In the search meeting, we discussed renaming feature_vector to feature_map instead, which still nicely conveys the information that this is a multivalued version of the feature field but without introducing confusion with the dense_vector and sparse_vector fields.

We agreed to create an issue with the discuss label to get this idea validated by a wider audience in Fixit Thursday/Friday.

None of these fields are released yet so there is no concern around backward compatibility.

Thoughts?
@jpountz jpountz added discuss :Search Foundations/Mapping Index mappings, including merging and defining field types labels Dec 17, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@mayya-sharipova
Copy link
Contributor

Inserting links here for: feature and feature_vector

Ad also I was wondering if can call feature_vector just features?
Another alternative is rank_features (this is how Vespa calls them).

@jpountz
Copy link
Contributor Author

jpountz commented Jan 14, 2019

I like rank_features.

mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this issue Jan 24, 2019
@mayya-sharipova
Rename feature, feature_vector and feature_query
e970ba1 
Ranaming as follows:
feature -> rank_feature
feature_vector -> rank_features
feature query -> rank_feature query

Ranaming is done to distinguish from other vector types.

Closes elastic#36723
@mayya-sharipova mayya-sharipova mentioned this issue Jan 24, 2019
Merged
mayya-sharipova added a commit that referenced this issue Jan 25, 2019
@mayya-sharipova
Rename feature, feature_vector and feature_query (#37794)
a30ce6a 
Ranaming as follows:
feature -> rank_feature
feature_vector -> rank_features
feature query -> rank_feature query

Ranaming is done to distinguish from other vector types.

Closes #36723
@javanna javanna added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayya-sharipova mayya-sharipova

Labels
>non-issue :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jpountz @javanna @mayya-sharipova @elasticmachine @jimczi @tomcallahan