Skip to content

SQL: StackOverflow circuit breaker kicks in for IN with a long list of numbers #38571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matriv opened this issue Feb 7, 2019 · 1 comment · Fixed by #38572
Closed

SQL: StackOverflow circuit breaker kicks in for IN with a long list of numbers #38571

matriv opened this issue Feb 7, 2019 · 1 comment · Fixed by #38572
Assignees
@matriv
Labels
:Analytics/SQL SQL querying >bug

Comments

@matriv
Copy link
Contributor

matriv commented Feb 7, 2019

Long list of numbers (positive and negative) inside IN kicks in when 200 numbers are encountered.
This shouldn't be the case as constants (numbers or strings) don't contribute to the increase of the stack.
@matriv matriv added >bug :Analytics/SQL SQL querying labels Feb 7, 2019
@matriv matriv self-assigned this Feb 7, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

matriv added a commit to matriv/elasticsearch that referenced this issue Feb 7, 2019
@matriv
SQL: Relax StatckOverflow circuit breaker for constants
d93d08d 
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: elastic#38571
@matriv matriv mentioned this issue Feb 7, 2019
Merged
matriv added a commit that referenced this issue Feb 9, 2019
@matriv
SQL: Relax StackOverflow circuit breaker for constants (#38572)
115ad24 
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: #38571
matriv added a commit that referenced this issue Feb 9, 2019
@matriv
SQL: Relax StackOverflow circuit breaker for constants (#38572)
871036b 
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: #38571
matriv added a commit that referenced this issue Feb 9, 2019
@matriv
SQL: Relax StackOverflow circuit breaker for constants (#38572)
b81dff6 
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: #38571
matriv added a commit that referenced this issue Feb 9, 2019
@matriv
SQL: Relax StackOverflow circuit breaker for constants (#38572)
7881639 
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: #38571
matriv added a commit that referenced this issue Feb 9, 2019
@matriv
SQL: Relax StackOverflow circuit breaker for constants (#38572)
1421da9 
Constant numbers (of any form: integers, decimals, negatives,
scientific) and strings shouldn't increase the depth counters
as they don't contribute to the increment of the stack depth.

Fixes: #38571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matriv matriv

Labels
:Analytics/SQL SQL querying >bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SQL: Relax StackOverflow circuit breaker for constants matriv/elasticsearch
2 participants
@matriv @elasticmachine