Skip to content

AsyncTwoPhaseIndexerTests testStateMachine CI failures #40946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidkyle opened this issue Apr 8, 2019 · 3 comments · Fixed by #40947
Closed

AsyncTwoPhaseIndexerTests testStateMachine CI failures #40946

davidkyle opened this issue Apr 8, 2019 · 3 comments · Fixed by #40947
Labels
:ml/Transform Transform :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data >test-failure Triaged test failures from CI

Comments

@davidkyle
Copy link
Member

Several failures with the error:

java.lang.AssertionError: 
Expected: <6>
     but: was <5>
	at __randomizedtesting.SeedInfo.seed([F2BBC735F05D6D51:9E12BB2E88D0733F]:0)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:956)
	at org.junit.Assert.assertThat(Assert.java:923)
	at org.elasticsearch.xpack.core.indexing.AsyncTwoPhaseIndexerTests.testStateMachine(AsyncTwoPhaseIndexerTests.java:224)

Does not reproduce:

./gradlew :x-pack:plugin:core:unitTest \
  -Dtests.seed=F2BBC735F05D6D51 \
  -Dtests.class=org.elasticsearch.xpack.core.indexing.AsyncTwoPhaseIndexerTests \
  -Dtests.method="testStateMachine" \
  -Dtests.security.manager=true \
  -Dtests.locale=en-ZM \
  -Dtests.timezone=Atlantic/Reykjavik \
  -Dcompiler.java=12 \
  -Druntime.java=11

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-unix-compatibility/os=centos-6/320/console
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.x+multijob-unix-compatibility/os=ubuntu-18.04&&immutable/95/console
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.x+multijob-unix-compatibility/os=ubuntu-18.04&&immutable/94/console
@davidkyle davidkyle added >test-failure Triaged test failures from CI :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data :ml/Transform Transform labels Apr 8, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Apr 8, 2019
@original-brownbear
Fix Race in AsyncTwoPhaseIndexerTests.testStateMachine
0e5f85a 
* The step is incremented by the listner in `org.elasticsearch.xpack.core.indexing.AsyncTwoPhaseIndexerTests.MockIndexer#onFinish` after isFinished is set to true, but the test only waited for `isFinished`,
fixed by calling `isFinished` last
* Also made `step` volatile since we are reading it from different thread from the one incrementing it
* Closes elastic#40946
@original-brownbear original-brownbear mentioned this issue Apr 8, 2019
Merged
@davidkyle
Copy link
Member Author

Muted in master 80c7c0e and 7.x fb5d7cf

original-brownbear added a commit that referenced this issue Apr 8, 2019
@original-brownbear
Fix Race in AsyncTwoPhaseIndexerTests.testStateMachine (#40947)
00a44b0 
* The step is incremented by the listner in `org.elasticsearch.xpack.core.indexing.AsyncTwoPhaseIndexerTests.MockIndexer#onFinish` after isFinished is set to true, but the test only waited for `isFinished`,
fixed by calling `isFinished` last
* Also made `step` volatile since we are reading it from different thread from the one incrementing it
* Closes #40946
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Apr 9, 2019
@original-brownbear
Fix Race in AsyncTwoPhaseIndexerTests.testStateMachine (elastic#40947)
aa2f318 
* The step is incremented by the listner in `org.elasticsearch.xpack.core.indexing.AsyncTwoPhaseIndexerTests.MockIndexer#onFinish` after isFinished is set to true, but the test only waited for `isFinished`,
fixed by calling `isFinished` last
* Also made `step` volatile since we are reading it from different thread from the one incrementing it
* Closes elastic#40946
@original-brownbear original-brownbear mentioned this issue Apr 9, 2019
Merged
original-brownbear added a commit that referenced this issue Apr 9, 2019
@original-brownbear
Fix Race in AsyncTwoPhaseIndexerTests.testStateMachine (#40947) (#41013)
e71db05 
* The step is incremented by the listner in `org.elasticsearch.xpack.core.indexing.AsyncTwoPhaseIndexerTests.MockIndexer#onFinish` after isFinished is set to true, but the test only waited for `isFinished`,
fixed by calling `isFinished` last
* Also made `step` volatile since we are reading it from different thread from the one incrementing it
* Closes #40946
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this issue May 27, 2019
@original-brownbear
Fix Race in AsyncTwoPhaseIndexerTests.testStateMachine (elastic#40947)
5187f87 
* The step is incremented by the listner in `org.elasticsearch.xpack.core.indexing.AsyncTwoPhaseIndexerTests.MockIndexer#onFinish` after isFinished is set to true, but the test only waited for `isFinished`,
fixed by calling `isFinished` last
* Also made `step` volatile since we are reading it from different thread from the one incrementing it
* Closes elastic#40946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:ml/Transform Transform :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Race in AsyncTwoPhaseIndexerTests.testStateMachine original-brownbear/elasticsearch
2 participants
@davidkyle @elasticmachine