Skip to content

[ML] Improve error message when the native controller fails to start #42341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidkyle opened this issue May 22, 2019 · 2 comments · Fixed by #43565
Closed

[ML] Improve error message when the native controller fails to start #42341

davidkyle opened this issue May 22, 2019 · 2 comments · Fixed by #43565
Assignees
Labels
:ml Machine learning

Comments

@davidkyle
Copy link
Member

The native controller may fail on unsupported platforms if, for instance, a required library is missing. This prevents the node from starting:

org.elasticsearch.bootstrap.StartupException: ElasticsearchException[Failed to create native process factories for Machine Learning]; 
nested: FileNotFoundException[/elasticsearch_tmp/controller_log_7428 (No such file or directory)];

The error message explains the cause but not the remedy. If ml is not required the solution is to disable it xpack.ml.enabled: false and the node will start fine.

Relates to #41867
Also review the number of nested exceptions in the stack trace and cut the noise.

@davidkyle davidkyle added the :ml Machine learning label May 22, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@droberts195
Copy link
Contributor

The comment above the line that throws the error suggests that it was not intended to be seen:

// This also should not happen in production, as the MachineLearningFeatureSet should have
// hit the same error first and brought down the node with a friendlier error message

But since that comment was written (for 5.4) other refactoring has obviously changed the point at which the problem of not being able to talk to the native controller is detected.

@droberts195 droberts195 self-assigned this Jun 25, 2019
droberts195 added a commit to droberts195/elasticsearch that referenced this issue Jun 25, 2019
The error message if the native controller failed to run
(for example due to running Elasticsearch on an unsupported
platform) was not easy to understand.  This change removes
pointless detail from the message and adds some hints about
likely causes.

Fixes elastic#42341
droberts195 added a commit that referenced this issue Jun 25, 2019
The error message if the native controller failed to run
(for example due to running Elasticsearch on an unsupported
platform) was not easy to understand.  This change removes
pointless detail from the message and adds some hints about
likely causes.

Fixes #42341
droberts195 added a commit that referenced this issue Jun 25, 2019
The error message if the native controller failed to run
(for example due to running Elasticsearch on an unsupported
platform) was not easy to understand.  This change removes
pointless detail from the message and adds some hints about
likely causes.

Fixes #42341
droberts195 added a commit that referenced this issue Jun 25, 2019
The error message if the native controller failed to run
(for example due to running Elasticsearch on an unsupported
platform) was not easy to understand.  This change removes
pointless detail from the message and adds some hints about
likely causes.

Fixes #42341
droberts195 added a commit that referenced this issue Jun 25, 2019
The error message if the native controller failed to run
(for example due to running Elasticsearch on an unsupported
platform) was not easy to understand.  This change removes
pointless detail from the message and adds some hints about
likely causes.

Fixes #42341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants