-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Inconsistent segment stats with soft-deletes #43103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pinging @elastic/es-distributed |
I opened #43126 to propose the fix for the delete count issue. |
At first glance, these numbers would be useful. However, soft-deletes and hard-deletes are exclusive. If soft-deletes is enabled, we won't have hard-deletes (except situations where we hit non-abortable exceptions during indexing) and vice versa. |
This change fixes the delete count issue in segment stats where we don't account soft-deleted documents from committed segments. Relates #43103
This change fixes the delete count issue in segment stats where we don't account soft-deleted documents from committed segments. Relates #43103
This change fixes the delete count issue in segment stats where we don't account soft-deleted documents from committed segments. Relates #43103
This change fixes the delete count issue in segment stats where we don't account soft-deleted documents from committed segments. Relates #43103
This change fixes the delete count issue in segment stats where we don't account soft-deleted documents from committed segments. Relates #43103
ok, sounds good. |
Segment stats are currently inconsistent when it comes to (soft-)deletes. The number of deletes are counted in a different way for non-searchable committed segment infos than for searchable ones, e.g. soft-deletes are not treated as deletes in committed segment infos.
We should make sure to have segment infos record the number of soft deletes as well, so that we return consistent numbers, and preferably also return information regarding the count of soft-deletes vs hard-deletes in the API.
The text was updated successfully, but these errors were encountered: