ILM prohibits stopping when in shrink action instead of shrink step #43253
Assignees
Labels
Comments
dakrone
added
>bug
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-features |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this issue
Jun 14, 2019
Prior to this change, we would prevent stopping of ILM if the index was anywhere in the shrink action. This commit changes `IndexLifecycleService` to allow stopping when in any of the innocuous steps during shrink. This changes ILM only to prevent stopping if absolutely necessary. Resolves elastic#43253
dakrone
added a commit
that referenced
this issue
Jun 19, 2019
* Narrow period of Shrink action in which ILM prevents stopping Prior to this change, we would prevent stopping of ILM if the index was anywhere in the shrink action. This commit changes `IndexLifecycleService` to allow stopping when in any of the innocuous steps during shrink. This changes ILM only to prevent stopping if absolutely necessary. Resolves #43253 * Rename variable for ignore actions -> ignore steps * Fix comment * Factor test out to test *all* stoppable steps
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this issue
Jun 19, 2019
…c#43254) * Narrow period of Shrink action in which ILM prevents stopping Prior to this change, we would prevent stopping of ILM if the index was anywhere in the shrink action. This commit changes `IndexLifecycleService` to allow stopping when in any of the innocuous steps during shrink. This changes ILM only to prevent stopping if absolutely necessary. Resolves elastic#43253 * Rename variable for ignore actions -> ignore steps * Fix comment * Factor test out to test *all* stoppable steps
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this issue
Jun 19, 2019
…c#43254) * Narrow period of Shrink action in which ILM prevents stopping Prior to this change, we would prevent stopping of ILM if the index was anywhere in the shrink action. This commit changes `IndexLifecycleService` to allow stopping when in any of the innocuous steps during shrink. This changes ILM only to prevent stopping if absolutely necessary. Resolves elastic#43253 * Rename variable for ignore actions -> ignore steps * Fix comment * Factor test out to test *all* stoppable steps
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this issue
Jun 19, 2019
…c#43254) * Narrow period of Shrink action in which ILM prevents stopping Prior to this change, we would prevent stopping of ILM if the index was anywhere in the shrink action. This commit changes `IndexLifecycleService` to allow stopping when in any of the innocuous steps during shrink. This changes ILM only to prevent stopping if absolutely necessary. Resolves elastic#43253 * Rename variable for ignore actions -> ignore steps * Fix comment * Factor test out to test *all* stoppable steps
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this issue
Jun 19, 2019
…c#43254) * Narrow period of Shrink action in which ILM prevents stopping Prior to this change, we would prevent stopping of ILM if the index was anywhere in the shrink action. This commit changes `IndexLifecycleService` to allow stopping when in any of the innocuous steps during shrink. This changes ILM only to prevent stopping if absolutely necessary. Resolves elastic#43253 * Rename variable for ignore actions -> ignore steps * Fix comment * Factor test out to test *all* stoppable steps
dakrone
added a commit
that referenced
this issue
Jun 19, 2019
…43254) (#43396) * Narrow period of Shrink action in which ILM prevents stopping Prior to this change, we would prevent stopping of ILM if the index was anywhere in the shrink action. This commit changes `IndexLifecycleService` to allow stopping when in any of the innocuous steps during shrink. This changes ILM only to prevent stopping if absolutely necessary. Resolves #43253 * Rename variable for ignore actions -> ignore steps * Fix comment * Factor test out to test *all* stoppable steps
dakrone
added a commit
that referenced
this issue
Jun 19, 2019
…43254) (#43395) * Narrow period of Shrink action in which ILM prevents stopping Prior to this change, we would prevent stopping of ILM if the index was anywhere in the shrink action. This commit changes `IndexLifecycleService` to allow stopping when in any of the innocuous steps during shrink. This changes ILM only to prevent stopping if absolutely necessary. Resolves #43253 * Rename variable for ignore actions -> ignore steps * Fix comment * Factor test out to test *all* stoppable steps
dakrone
added a commit
that referenced
this issue
Jun 19, 2019
…43254) (#43394) * Narrow period of Shrink action in which ILM prevents stopping Prior to this change, we would prevent stopping of ILM if the index was anywhere in the shrink action. This commit changes `IndexLifecycleService` to allow stopping when in any of the innocuous steps during shrink. This changes ILM only to prevent stopping if absolutely necessary. Resolves #43253 * Rename variable for ignore actions -> ignore steps * Fix comment * Factor test out to test *all* stoppable steps
dakrone
added a commit
that referenced
this issue
Jun 19, 2019
…43254) (#43393) * Narrow period of Shrink action in which ILM prevents stopping Prior to this change, we would prevent stopping of ILM if the index was anywhere in the shrink action. This commit changes `IndexLifecycleService` to allow stopping when in any of the innocuous steps during shrink. This changes ILM only to prevent stopping if absolutely necessary. Resolves #43253 * Rename variable for ignore actions -> ignore steps * Fix comment * Factor test out to test *all* stoppable steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When attempting to stop ILM, ILM checks to see if any of the indices are currently shrinking to avoid stopping during this operation. However, the check for this is too coarse-grained, checking to see if the index is in the "shrink" action instead of the actual "shrink" step (where the actual shrink call is issued).
This can lead to issues where an index is in the shrink but doing something innocuous, but still prevents ILM from shutting down. Even worse is when the index is in the shrink action, but in the ERROR step, where ILM should definitely not be prevented from stopping.
The text was updated successfully, but these errors were encountered: