Skip to content

Remove redundant setting for adjacency_matrix aggregation #46324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markharwood opened this issue Sep 4, 2019 · 1 comment · Fixed by #46327
Closed

Remove redundant setting for adjacency_matrix aggregation #46324

markharwood opened this issue Sep 4, 2019 · 1 comment · Fixed by #46327
Assignees
@markharwood
Labels
:Analytics/Aggregations Aggregations

Comments

@markharwood
Copy link
Contributor

Now that #46257 has improved internal memory usage we no longer need the default limit of 100 filters defined by index.max_adjacency_matrix_filters.

We decided on the following changes:

In 7.x continue to use index.max_adjacency_matrix_filters setting but start using indices.query.bool.max_clause_count as the new default value for the setting and return deprecation warnings for any user-supplied settings.
In 8.0 remove index.max_adjacency_matrix_filters setting and rely solely on indices.query.bool.max_clause_count.
@markharwood markharwood self-assigned this Sep 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@markharwood markharwood mentioned this issue Sep 4, 2019
Merged
@markharwood markharwood mentioned this issue Sep 5, 2019
Merged
markharwood added a commit to markharwood/elasticsearch that referenced this issue Sep 6, 2019
@markharwood
Deprecate the "index.max_adjacency_matrix_filters" setting.
6e6e8d2 
Related elastic#46324
markharwood added a commit that referenced this issue Sep 6, 2019
@markharwood
Deprecate the "index.max_adjacency_matrix_filters" index setting (#46394
323ec02 
)

Following performance optimisations to the adjacency_matrix aggregation we no longer require this setting. Marked as deprecated and due for removal in 8.0

Related #46324
markharwood added a commit to markharwood/elasticsearch that referenced this issue Sep 19, 2019
@markharwood
Remove Adjacency_matrix setting in favour of Lucene Boolean query cla…
e782116 
…use setting

Closes elastic#46324
markharwood added a commit that referenced this issue Sep 19, 2019
@markharwood
Remove Adjacency_matrix setting in favour of Lucene Boolean query cla…
dc0abec 
…use setting (#46327)

Closes #46324
@hkulekci hkulekci mentioned this issue Feb 17, 2022
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markharwood markharwood

Labels
:Analytics/Aggregations Aggregations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Adjacency_matrix setting markharwood/elasticsearch
2 participants
@markharwood @elasticmachine