Consistent REST Get Field Mapping API #4738
Assignees
Labels
Comments
ghost
assigned 
spinscale
added a commit
that referenced
this issue
Jan 28, 2014
If a get field mapping request is issued, and all but the field can be found, the response should return an empty JSON object instead of a 404. Closes #4738
spinscale
added a commit
that referenced
this issue
Jan 28, 2014
If a get field mapping request is issued, and all but the field can be found, the response should return an empty JSON object instead of a 404. Closes #4738
spinscale
added a commit
to spinscale/elasticsearch
that referenced
this issue
Jan 30, 2014
When fixing elastic#4738, a small issue leaked into the implementation. The equals check in the RestAction only applied when the master node returned the rest request, otherwise the object equality would not hold due to being transferred over the wire and being deserialized into another object (from and an equality point of view) than the FieldMappingMetaData.NULL object - this could result in serialization exceptions as an empty length bytes reference is used in toXContent.
spinscale
added a commit
that referenced
this issue
Jan 30, 2014
When fixing #4738, a small issue leaked into the implementation. The equals check in the RestAction only applied when the master node returned the rest request, otherwise the object equality would not hold due to being transferred over the wire and being deserialized into another object (from and an equality point of view) than the FieldMappingMetaData.NULL object - this could result in serialization exceptions as an empty length bytes reference is used in toXContent.
spinscale
added a commit
that referenced
this issue
Jan 30, 2014
When fixing #4738, a small issue leaked into the implementation. The equals check in the RestAction only applied when the master node returned the rest request, otherwise the object equality would not hold due to being transferred over the wire and being deserialized into another object (from and an equality point of view) than the FieldMappingMetaData.NULL object - this could result in serialization exceptions as an empty length bytes reference is used in toXContent.
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
If a get field mapping request is issued, and all but the field can be found, the response should return an empty JSON object instead of a 404. Closes elastic#4738
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
When fixing elastic#4738, a small issue leaked into the implementation. The equals check in the RestAction only applied when the master node returned the rest request, otherwise the object equality would not hold due to being transferred over the wire and being deserialized into another object (from and an equality point of view) than the FieldMappingMetaData.NULL object - this could result in serialization exceptions as an empty length bytes reference is used in toXContent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of #4071, this commit a3abcdc prepared the Get Field Mapping API. However, if index and type exist, but the field does not, it should return an empty JSON response instead of a 404 in order to be consistent.
Right now, you cannot now, if the index, type or field was the one not being found in in the rest action
The text was updated successfully, but these errors were encountered: