Skip to content

ingest-user-agent: code/documentation mismatch for regex_file option #48682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AE777F63 opened this issue Oct 30, 2019 · 2 comments · Fixed by #48688
Closed

ingest-user-agent: code/documentation mismatch for regex_file option #48682

AE777F63 opened this issue Oct 30, 2019 · 2 comments · Fixed by #48688
Assignees
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes

Comments

@AE777F63
Copy link

Elasticsearch version (bin/elasticsearch --version):
Version: 7.2.0, Build: oss/tar/508c38a/2019-06-20T15:54:18.811730Z, JVM: 11.0.1

Plugins installed: []

JVM version (java -version):
openjdk 11.0.1 2018-10-16
OpenJDK Runtime Environment 18.9 (build 11.0.1+13)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.1+13, mixed mode)

Description of the problem including expected versus actual behavior:
The documentation states that regex_file is supposed to have .yaml extension, but apparently it has to be .yml. Setting regex_file to "regexes.yaml" does not work; "regexes.yml" does.

https://github.com/elastic/elasticsearch/blob/7.4/docs/reference/ingest/processors/user-agent.asciidoc#using-a-custom-regex-file
https://github.com/elastic/elasticsearch/blob/7.2/modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/IngestUserAgentPlugin.java#L72

Steps to reproduce:

  1. Put regexes.yaml to /usr/share/elasticsearch/config/ingest-user-agent/regexes.yaml
  2. Set regex_field to "regexes.yaml" in pipeline configuration
  3. Start elasticsearch and see that it does not load regexes.yaml
@jimczi jimczi added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes labels Oct 30, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants