Skip to content

[DOCS] Correct required file ext for user agent ingest processor #48688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2019
Merged

[DOCS] Correct required file ext for user agent ingest processor #48688

merged 1 commit into from
Oct 30, 2019

Conversation

jrodewig
Copy link
Contributor

For the user agent ingest processor, custom regex files must end with the .yml file extension:

https://github.com/elastic/elasticsearch/blob/master/modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/IngestUserAgentPlugin.java#L73

This corrects the docs which said the .yaml extension was required.

Closes #48682

For the user agent ingest processor, custom regex files must end
with the `.yml` file extension.

This corrects the docs which said the `.yaml` extension was required.
@jrodewig jrodewig added >docs General docs changes :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.5.0 v7.6.0 v7.4.2 labels Oct 30, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrodewig jrodewig merged commit 4ccd3a2 into elastic:master Oct 30, 2019
@jrodewig jrodewig deleted the fix-ua-proc-ext branch October 30, 2019 15:10
jrodewig added a commit that referenced this pull request Oct 30, 2019
)

For the user agent ingest processor, custom regex files must end
with the `.yml` file extension.

This corrects the docs which said the `.yaml` extension was required.
jrodewig added a commit that referenced this pull request Oct 30, 2019
)

For the user agent ingest processor, custom regex files must end
with the `.yml` file extension.

This corrects the docs which said the `.yaml` extension was required.
jrodewig added a commit that referenced this pull request Oct 30, 2019
)

For the user agent ingest processor, custom regex files must end
with the `.yml` file extension.

This corrects the docs which said the `.yaml` extension was required.
@polyfractal polyfractal added v7.4.3 and removed v7.4.2 labels Oct 31, 2019
jrodewig added a commit that referenced this pull request Oct 31, 2019
)

For the user agent ingest processor, custom regex files must end
with the `.yml` file extension.

This corrects the docs which said the `.yaml` extension was required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >docs General docs changes v6.8.5 v7.4.3 v7.5.0 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ingest-user-agent: code/documentation mismatch for regex_file option
6 participants