-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Allow invalid values to be ignored #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Currently, the only field type that qualifies this is the |
Numeric fields that don't parse wouldn't qualify (or are they handled in creating the JSON or previous?) |
Yea, json already handles it, since it has native types for numbers. |
dandy. |
Also, there is now a flag for ignoring malformed values |
PR#491 introduced a check for the presence of `/etc/crypttab` but there was an Ansible bug that this commit fixes.
For datatypes that expect a specific format, allow a variation of the type that is a "softie" in that it allows bad things to just be ignored. This is important for unclean data, and although other work may allow you to write a document processing plugin to ES that can clean data (i.e. parse human readable dates into a standard form), it is sometimes likely you can have some rough data that you don't want to kill your indexing. Especially for fields that are not that important but you want a best attempt to insert the document.
You then could also consider marking documents that have validation errors so they could be later rescanned and reindexed given the stored JSON when a cleaner is added that would possibly resolve the problem. For example, mark the document as validation error for field XX and later search for those docs and ask the system "reindex document " from its own stored form.
So 3 things here:
The text was updated successfully, but these errors were encountered: