Skip to content

Add tests for IntervalsSourceProvider implementations #50150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cbuescher opened this issue Dec 12, 2019 · 3 comments · Fixed by #50326
Closed

Add tests for IntervalsSourceProvider implementations #50150

cbuescher opened this issue Dec 12, 2019 · 3 comments · Fixed by #50326
Labels
help wanted adoptme :Search/Search Search-related issues that do not fall into other categories >test Issues or PRs that are addressing/adding tests

Comments

@cbuescher
Copy link
Member

The implementations are partialy tested though the IntervalQueryBuilderTests and other tests, but since the class supports xContent and wire serialization, some dedicated tests (maybe extending AbstractWireTestCase, AbstractXContentTestCase or both) might be useful.

@cbuescher cbuescher added :Search/Search Search-related issues that do not fall into other categories >test Issues or PRs that are addressing/adding tests help wanted adoptme labels Dec 12, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@Hohol
Copy link
Contributor

Hohol commented Dec 13, 2019

May I take this?

@cbuescher
Copy link
Member Author

@Hohol sure, maybe start with one of the simpler ones to get yourself familiarized with the kind of serialization testing we are typically doing. I think IntervalsSourceProvider.Prefix is one of the easiest of the implementations. I think a test for this should try to extend AbstractSerializingTestCase that already takes away some boilerplate code for creating random instances and test that both our xContent serialization (what typically is passed as JSON through the REST layer) and the internal serialization works. You can take a look at e.g. at TaskInfoTests for inspiration how some of these tests look like and work from there. Hope that helps.

cbuescher pushed a commit that referenced this issue Dec 18, 2019
This PR adds unit tests for wire and xContent serialization of `IntervalsSourceProvider.Wildcard`
and `IntervalsSourceProvider.Prefix`.

Relates #50150
cbuescher pushed a commit that referenced this issue Dec 18, 2019
This PR adds unit tests for wire and xContent serialization of `IntervalsSourceProvider.Wildcard`
and `IntervalsSourceProvider.Prefix`.

Relates #50150
cbuescher pushed a commit that referenced this issue Jan 6, 2020
This PR adds unit tests for wire and xContent serialization of remaining IntervalsSourceProvider
implementations.

Closes #50150
cbuescher pushed a commit that referenced this issue Jan 6, 2020
This PR adds unit tests for wire and xContent serialization of remaining IntervalsSourceProvider
implementations.

Closes #50150
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
)

This PR adds unit tests for wire and xContent serialization of `IntervalsSourceProvider.Wildcard`
and `IntervalsSourceProvider.Prefix`.

Relates elastic#50150
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
…tic#50326)

This PR adds unit tests for wire and xContent serialization of remaining IntervalsSourceProvider
implementations.

Closes elastic#50150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted adoptme :Search/Search Search-related issues that do not fall into other categories >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants