-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Add tests for IntervalsSourceProvider implementations #50150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Pinging @elastic/es-search (:Search/Search) |
May I take this? |
@Hohol sure, maybe start with one of the simpler ones to get yourself familiarized with the kind of serialization testing we are typically doing. I think IntervalsSourceProvider.Prefix is one of the easiest of the implementations. I think a test for this should try to extend AbstractSerializingTestCase that already takes away some boilerplate code for creating random instances and test that both our xContent serialization (what typically is passed as JSON through the REST layer) and the internal serialization works. You can take a look at e.g. at |
This PR adds unit tests for wire and xContent serialization of `IntervalsSourceProvider.Wildcard` and `IntervalsSourceProvider.Prefix`. Relates #50150
This PR adds unit tests for wire and xContent serialization of `IntervalsSourceProvider.Wildcard` and `IntervalsSourceProvider.Prefix`. Relates #50150
This PR adds unit tests for wire and xContent serialization of remaining IntervalsSourceProvider implementations. Closes #50150
This PR adds unit tests for wire and xContent serialization of remaining IntervalsSourceProvider implementations. Closes #50150
) This PR adds unit tests for wire and xContent serialization of `IntervalsSourceProvider.Wildcard` and `IntervalsSourceProvider.Prefix`. Relates elastic#50150
…tic#50326) This PR adds unit tests for wire and xContent serialization of remaining IntervalsSourceProvider implementations. Closes elastic#50150
The implementations are partialy tested though the IntervalQueryBuilderTests and other tests, but since the class supports xContent and wire serialization, some dedicated tests (maybe extending AbstractWireTestCase, AbstractXContentTestCase or both) might be useful.
The text was updated successfully, but these errors were encountered: