Skip to content

CsvProcessorTests#testUntrimmed fails #50209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dnhatn opened this issue Dec 15, 2019 · 4 comments · Fixed by #50254 or #51962
Closed

CsvProcessorTests#testUntrimmed fails #50209

dnhatn opened this issue Dec 15, 2019 · 4 comments · Fixed by #50254 or #51962
Assignees
@probakowski
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >test-failure Triaged test failures from CI

Comments

@dnhatn
Copy link
Member

dnhatn commented Dec 15, 2019

This test failed in an 7.x intake build: https://gradle-enterprise.elastic.co/s/ignvzyeja77a2. This is reproducible.

org.elasticsearch.ingest.common.CsvProcessorTests > testUntrimmed {quote='} FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([5F99CFEE74FB3D07:C80ADE82161D92B]:0)
        at org.junit.Assert.fail(Assert.java:86)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertFalse(Assert.java:64)
        at org.junit.Assert.assertFalse(Assert.java:74)
        at org.elasticsearch.ingest.common.CsvProcessorTests.testUntrimmed(CsvProcessorTests.java:190)
REPRODUCE WITH: ./gradlew ':modules:ingest-common:test' --tests "org.elasticsearch.ingest.common.CsvProcessorTests.testUntrimmed {quote='}" -Dtests.seed=5F99CFEE74FB3D07 -Dtests.security.manager=true -Dtests.locale=en -Dtests.timezone=Australia/Melbourne -Dcompiler.java=13 -Druntime.java=8
@dnhatn dnhatn added >test-failure Triaged test failures from CI :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP labels Dec 15, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

@probakowski probakowski self-assigned this Dec 16, 2019
@probakowski
Copy link
Contributor

There's problem with test code, tests above fail if random document generator add field that should not be present. I'll push fix for that soon

@henningandersen
Copy link
Contributor

Failed again here: https://gradle-enterprise.elastic.co/s/tifk3drrvlpdm/tests/failed, both failures are reproducible:

./gradlew ':modules:ingest-common:test' --tests "org.elasticsearch.ingest.common.CsvProcessorTests.testUntrimmed {quote='}" -Dtests.seed=98F58CDA6FFFEF40 -Dtests.security.manager=true -Dtests.locale=zh -Dtests.timezone=Pacific/Gambier -Dcompiler.java=13 -Druntime.java=8

./gradlew ':modules:ingest-common:test' --tests "org.elasticsearch.ingest.common.CsvProcessorTests.testUntrimmed {quote=\"}" -Dtests.seed=98F58CDA6FFFEF40 -Dtests.security.manager=true -Dtests.locale=zh -Dtests.timezone=Pacific/Gambier -Dcompiler.java=13 -Druntime.java=8

@probakowski probakowski mentioned this issue Dec 16, 2019
Merged
probakowski added a commit that referenced this issue Dec 16, 2019
@probakowski
Fix flakiness in CsvProcessorTests (#50254)
caef1b3 
There's flakiness in CsvProcesorTests, where tests fail if random document generator add field that should not be present. This change cleans generated document from these problematic fields.

Closes #50209
probakowski added a commit to probakowski/elasticsearch that referenced this issue Dec 16, 2019
@probakowski
Fix flakiness in CsvProcessorTests (elastic#50254)
afb1d59 
There's flakiness in CsvProcesorTests, where tests fail if random document generator add field that should not be present. This change cleans generated document from these problematic fields.

Closes elastic#50209
probakowski added a commit that referenced this issue Dec 17, 2019
@probakowski
Fix flakiness in CsvProcessorTests (#50254) (#50256)
0efb241 
There's flakiness in CsvProcesorTests, where tests fail if random document generator add field that should not be present. This change cleans generated document from these problematic fields.

Closes #50209
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@probakowski @SivagurunathanV
Fix flakiness in CsvProcessorTests (elastic#50254)
b7b2c7c 
There's flakiness in CsvProcesorTests, where tests fail if random document generator add field that should not be present. This change cleans generated document from these problematic fields.

Closes elastic#50209
@ywelsch
Copy link
Contributor

ywelsch commented Feb 5, 2020

More failures of this: https://gradle-enterprise.elastic.co/s/ek32eo2mm2rk4

@ywelsch ywelsch reopened this Feb 5, 2020
probakowski added a commit to probakowski/elasticsearch that referenced this issue Feb 5, 2020
@probakowski
Avoid clash between source field and header field in CsvProcessorTests
8ff65f3 
This change fixes flakiness in `CsvProcessorTests` where source field
can be the same as one of the headers used by tests which messes up
asserts when we check that field is not present after processor run.

Closes elastic#50209
@probakowski probakowski mentioned this issue Feb 5, 2020
Merged
probakowski added a commit that referenced this issue Feb 7, 2020
@probakowski
Avoid clash between source field and header field in CsvProcessorTests (
4ea1b06 
#51962)

This change fixes flakiness in `CsvProcessorTests` where source field
can be the same as one of the headers used by tests which messes up
asserts when we check that field is not present after processor run.

Closes #50209
probakowski added a commit to probakowski/elasticsearch that referenced this issue Feb 7, 2020
@probakowski
Avoid clash between source field and header field in CsvProcessorTests (
6ce25af 
elastic#51962)

This change fixes flakiness in `CsvProcessorTests` where source field
can be the same as one of the headers used by tests which messes up
asserts when we check that field is not present after processor run.

Closes elastic#50209
probakowski added a commit that referenced this issue Feb 7, 2020
@probakowski
Avoid clash between source field and header field in CsvProcessorTests (
ac1bff6 
#51962) (#52072)

This change fixes flakiness in `CsvProcessorTests` where source field
can be the same as one of the headers used by tests which messes up
asserts when we check that field is not present after processor run.

Closes #50209
probakowski added a commit that referenced this issue Feb 7, 2020
@probakowski
Avoid clash between source field and header field in CsvProcessorTests (
c827f6f 
#51962) (#52070)

This change fixes flakiness in `CsvProcessorTests` where source field
can be the same as one of the headers used by tests which messes up
asserts when we check that field is not present after processor run.

Closes #50209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@probakowski probakowski

Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
5 participants
@ywelsch @probakowski @dnhatn @elasticmachine @henningandersen