Skip to content

InternalEngineTests testShouldPeriodicallyFlushAfterMerge failure #52205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidkyle opened this issue Feb 11, 2020 · 1 comment · Fixed by #52243
Closed

InternalEngineTests testShouldPeriodicallyFlushAfterMerge failure #52205

davidkyle opened this issue Feb 11, 2020 · 1 comment · Fixed by #52243
Assignees
@dnhatn
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test-failure Triaged test failures from CI v7.5.0

Comments

@davidkyle
Copy link
Member 

java.lang.AssertionError: 
Expected: <false>
     but: was <true>
	at __randomizedtesting.SeedInfo.seed([D9AEEA268A616C55:DFF296783E7FFD87]:0)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
	at org.junit.Assert.assertThat(Assert.java:956)
	at org.junit.Assert.assertThat(Assert.java:923)
	at org.elasticsearch.index.engine.InternalEngineTests.testShouldPeriodicallyFlushAfterMerge(InternalEngineTests.java:5127)

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+7.5+matrix-java-periodic/ES_RUNTIME_JAVA=corretto11,nodes=general-purpose/236/console
https://gradle-enterprise.elastic.co/s/k5bsk266lz67c

Reproduce

./gradlew ':server:test' --tests "org.elasticsearch.index.engine.InternalEngineTests.testShouldPeriodicallyFlushAfterMerge" \
  -Dtests.seed=D9AEEA268A616C55 \
  -Dtests.security.manager=true \
  -Dtests.locale=ky \
  -Dtests.timezone=Etc/GMT-14 \
  -Dcompiler.java=12 \
  -Druntime.java=11
@davidkyle davidkyle added :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v7.5.0 labels Feb 11, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

@davidkyle davidkyle added the >test-failure Triaged test failures from CI label Feb 11, 2020
@dnhatn dnhatn self-assigned this Feb 11, 2020
@dnhatn dnhatn mentioned this issue Feb 11, 2020
Merged
dnhatn added a commit that referenced this issue Feb 12, 2020
@dnhatn
Fix testShouldPeriodicallyFlushAfterMerge (#52243)
a74ba9c 
MockRandomMergePolicy randomly determines if a segment should use a 
compound format. This can cause a force merge performing two merges: (1)
merging to a single segment, (2) rewriting the new segment using the
compound format. If the second merge completes after we have flushed,
then it can flip the flag shouldPeriodicallyFlushAfterBigMerge to true.

Closes #52205
dnhatn added a commit that referenced this issue Feb 12, 2020
@dnhatn
Fix testShouldPeriodicallyFlushAfterMerge (#52243)
e098e83 
MockRandomMergePolicy randomly determines if a segment should use a 
compound format. This can cause a force merge performing two merges: (1)
merging to a single segment, (2) rewriting the new segment using the
compound format. If the second merge completes after we have flushed,
then it can flip the flag shouldPeriodicallyFlushAfterBigMerge to true.

Closes #52205
dnhatn added a commit that referenced this issue Feb 12, 2020
@dnhatn
Fix testShouldPeriodicallyFlushAfterMerge (#52243)
8ba37ed 
MockRandomMergePolicy randomly determines if a segment should use a 
compound format. This can cause a force merge performing two merges: (1)
merging to a single segment, (2) rewriting the new segment using the
compound format. If the second merge completes after we have flushed,
then it can flip the flag shouldPeriodicallyFlushAfterBigMerge to true.

Closes #52205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnhatn dnhatn

Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test-failure Triaged test failures from CI v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exclude MockRandomMergePolicy in testShouldPeriodicallyFlushAfterMerge dnhatn/elasticsearch
3 participants
@davidkyle @dnhatn @elasticmachine