-
Notifications
You must be signed in to change notification settings - Fork 25.2k
GCS SDK does not resume downloads that fail part-way through #52319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>enhancement
Comments
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this issue
Feb 18, 2020
Exactly as elastic#46589 (and kept as close to it as possible code wise so we can dry things up in a follow-up potentially) but for GCS. Closes elastic#52319
original-brownbear
added a commit
that referenced
this issue
Feb 19, 2020
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this issue
Feb 19, 2020
* Add Blob Download Retries to GCS Repository Exactly as elastic#46589 (and kept as close to it as possible code wise so we can dry things up in a follow-up potentially) but for GCS. Closes elastic#52319
sbourke
pushed a commit
to sbourke/elasticsearch
that referenced
this issue
Feb 19, 2020
* Add Blob Download Retries to GCS Repository Exactly as elastic#46589 (and kept as close to it as possible code wise so we can dry things up in a follow-up potentially) but for GCS. Closes elastic#52319
original-brownbear
added a commit
that referenced
this issue
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>enhancement
A connection dropped part-way through the download of a blob from GCS is not today considered retryable by the SDK, so a restore from GCS over a flaky connection may fail and need to be retried from the beginning.
I've seen two different (but related) exceptions:
l.e. I've seen
java.io.IOException: Connection reset
andjavax.net.ssl.SSLException: Connection reset
, neither of which seem to be retryableRelates #46589, which works around the same issue in the AWS S3 SDK.
Quoting googleapis/java-storage#26 (comment):
This seems to ignore the fact that connection drops are often transient and resuming the download is often the right way to proceed. Still, at least it's a clear statement of intent, and indicates that maybe we need to implement our own resume functionality to work around this for now.
The text was updated successfully, but these errors were encountered: