Skip to content

[DOCS] Terms agg doc counts are more precise than documented. #52377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jrodewig opened this issue Feb 14, 2020 · 9 comments · Fixed by #55442
Closed

[DOCS] Terms agg doc counts are more precise than documented. #52377

jrodewig opened this issue Feb 14, 2020 · 9 comments · Fixed by #55442
Labels
:Analytics/Aggregations Aggregations >docs General docs changes

Comments

@jrodewig
Copy link
Contributor

jrodewig commented Feb 14, 2020 •
edited
Loading

The terms aggregation docs include a Document count are approximate section.

When reproduced on 6.8 or 7.x, the actual results are more precise than documented in last table and paragraphs of the section.

Steps to reproduce

https://gist.github.com/geekpete/38c06b2eaf2745c3b7312d329acb01fd

Thanks to @geekpete for raising and putting together the reproduction steps.
@jrodewig jrodewig added >docs General docs changes :Analytics/Aggregations Aggregations labels Feb 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@jrodewig jrodewig changed the title [DOCS] Terms agg doc counts are more accurate than documented. [DOCS] Terms agg doc counts are more precise than documented. Feb 14, 2020
@abprash
Copy link
Contributor

abprash commented Apr 17, 2020

Can i work on this one?

@jrodewig
Copy link
Contributor Author

@abprash A PR would be welcome. Thanks.

@abprash
Copy link
Contributor

abprash commented Apr 18, 2020

Thank you @jrodewig . Working on it. Will submit a PR when done.
Would like to get clarified on the process followed, Would this issue need to be assigned to me?

@geekpete
Copy link
Member

The repro steps were in a private gist, I made it public.

@abprash
Copy link
Contributor

abprash commented Apr 20, 2020

Thanks @geekpete

@abprash abprash mentioned this issue Apr 23, 2020
Merged
@abprash
Copy link
Contributor

abprash commented Apr 25, 2020

@geekpete @jrodewig Not sure, how it usually goes, would you mind reviewing my PR?

@jrodewig
Copy link
Contributor Author

@abprash I'll take a look when time permits. Thanks for raising this!

@jrodewig jrodewig mentioned this issue Apr 30, 2020
Closed
jrodewig added a commit that referenced this issue Apr 30, 2020
@abprash @jrodewig
[DOCS] Remove approximate document counts example from term agg docs (#…
785527b 
…55442)

Removes an example from the "Document counts are approximate" section of the
terms agg documentation.

As #52377 details, the example was no longer accurate in 7.x or 6.8. Document
counts were more precise than the example presented.

We've opened issue #56025 to discuss re-adding an example later.

Co-authored-by: James Rodewig <[email protected]>
jrodewig added a commit that referenced this issue Apr 30, 2020
@jrodewig @abprash
[DOCS] Remove approximate document counts example from term agg docs (#…
e4e02e1 
…55442)

Removes an example from the "Document counts are approximate" section of the
terms agg documentation.

As #52377 details, the example was no longer accurate in 7.x or 6.8. Document
counts were more precise than the example presented.

We've opened issue #56025 to discuss re-adding an example later.

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: AB Prashanth <[email protected]>
jrodewig added a commit that referenced this issue Apr 30, 2020
@jrodewig @abprash
[DOCS] Remove approximate document counts example from term agg docs (#…
8846ffd 
…55442)

Removes an example from the "Document counts are approximate" section of the
terms agg documentation.

As #52377 details, the example was no longer accurate in 7.x or 6.8. Document
counts were more precise than the example presented.

We've opened issue #56025 to discuss re-adding an example later.

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: AB Prashanth <[email protected]>
jrodewig added a commit that referenced this issue Apr 30, 2020
@jrodewig @abprash
[DOCS] Remove approximate document counts example from term agg docs (#…
c0a9975 
…55442)

Removes an example from the "Document counts are approximate" section of the
terms agg documentation.

As #52377 details, the example was no longer accurate in 7.x or 6.8. Document
counts were more precise than the example presented.

We've opened issue #56025 to discuss re-adding an example later.

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: AB Prashanth <[email protected]>
jrodewig added a commit that referenced this issue Apr 30, 2020
@jrodewig @abprash
[DOCS] Remove approximate document counts example from term agg docs (#…
ce1aaec 
…55442) (#56043)

Removes an example from the "Document counts are approximate" section of the
terms agg documentation.

As #52377 details, the example was no longer accurate in 7.x or 6.8. Document
counts were more precise than the example presented.

We've opened issue #56025 to discuss re-adding an example later.

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: AB Prashanth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations >docs General docs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DOCS] Remove approximate document counts example from term agg docs abprash/elasticsearch
4 participants
@geekpete @elasticmachine @abprash @jrodewig