Skip to content

EQL: Change request parameter query to filter and rule to query #52911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
costin opened this issue Feb 27, 2020 · 2 comments
Closed

EQL: Change request parameter query to filter and rule to query #52911

costin opened this issue Feb 27, 2020 · 2 comments
Assignees
@aleksmaus
Labels
:Analytics/EQL EQL querying

Comments

@costin
Copy link
Member

costin commented Feb 27, 2020

Currently EQL requests use rule to specify a query - this should be aligned with the existing terminology and be renamed to query for consistency with the rest of the APIs, while the existing query param, used for passing a query dsl for filtering, renamed to filter.
@costin costin added the :Analytics/EQL EQL querying label Feb 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/EQL)

aleksmaus added a commit to aleksmaus/elasticsearch that referenced this issue Feb 28, 2020
@aleksmaus
EQL: Change request parameter query to filter and rule to query
107a507 
Related to elastic#52911
@aleksmaus aleksmaus mentioned this issue Feb 28, 2020
Merged
aleksmaus added a commit that referenced this issue Mar 2, 2020
@aleksmaus
EQL: Change request parameter query to filter and rule to query (#52971)
d49a9aa 
* EQL: Change request parameter query to filter and rule to query

Related to #52911

* Adjust doc test
aleksmaus added a commit to aleksmaus/elasticsearch that referenced this issue Mar 2, 2020
@aleksmaus
EQL: Change request parameter query to filter and rule to query (elas…
3ac814f 
…tic#52971)

* EQL: Change request parameter query to filter and rule to query

Related to elastic#52911

* Adjust doc test
@aleksmaus aleksmaus mentioned this issue Mar 2, 2020
Merged
aleksmaus added a commit that referenced this issue Mar 2, 2020
@aleksmaus
EQL: Change request parameter query to filter and rule to query (#52971…
89ed857 
…) (#53006)

Related to #52911
@aleksmaus
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aleksmaus aleksmaus

Labels
:Analytics/EQL EQL querying
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@costin @aleksmaus @elasticmachine