Skip to content

EQL: implement concat function #55185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rw-access opened this issue Apr 14, 2020 · 1 comment · Fixed by #55193
Closed

EQL: implement concat function #55185

rw-access opened this issue Apr 14, 2020 · 1 comment · Fixed by #55193
Assignees
Labels
:Analytics/EQL EQL querying Team:QL (Deprecated) Meta label for query languages team

Comments

@rw-access
Copy link
Contributor

rw-access commented Apr 14, 2020

Part of #51556

Call toString() on all the non-null input arguments.

For the null behavior, we could go one of three ways:

  • if any of the inputs are null, return null
  • if all of the inputs are null, return null
  • return an empty string, if all inputs are null

Update from 2020/04/23:

  • We decided to go with the first option. All inputs are required, so if any are missing, we will return null. This will be more consistent with other functions, and make the strings within concat more consistently parseable.
@rw-access rw-access added the :Analytics/EQL EQL querying label Apr 14, 2020
@rw-access rw-access self-assigned this Apr 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/EQL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/EQL EQL querying Team:QL (Deprecated) Meta label for query languages team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants