Skip to content

[DOCS] EQL: Document concat function #56239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2020
Merged

[DOCS] EQL: Document concat function #56239

merged 2 commits into from
May 5, 2020

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented May 5, 2020

Relates to #55193 and #55185

@jrodewig jrodewig added >docs General docs changes :Analytics/EQL EQL querying labels May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/EQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label May 5, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label May 5, 2020
@jrodewig jrodewig requested a review from rw-access May 5, 2020 19:57

`<value>`::
(Required{multi-arg-ref})
Value to concatenate. If `null`, the function returns `null`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong grasp on the verbiage for multi-arg-ref

Suggested change
Value to concatenate. If `null`, the function returns `null`.
Value to concatenate. If any of the arguments are `null`, the function returns `null`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this clarification is good regardless. Thanks for adding.

The {multi-arg-ref} attribute creates a footnote link to the following text:

This parameter accepts multiple arguments.

Here's a screenshot from the wildcard function, which happens to be near the footnote at the bottom of the page.

Screen Shot 2020-05-05 at 4 24 47 PM

@jrodewig
Copy link
Contributor Author

jrodewig commented May 5, 2020

Thanks @rw-access

@jrodewig jrodewig merged commit c7ac7e0 into elastic:master May 5, 2020
@jrodewig jrodewig deleted the docs__eql-fn-concat branch May 5, 2020 20:42
jrodewig added a commit that referenced this pull request May 5, 2020
@jrodewig
Copy link
Contributor Author

jrodewig commented May 5, 2020

Backport commits

master c7ac7e0
7.x 8686200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/EQL EQL querying >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants