Skip to content

Remove cacheKeyRenderer from IndicesRequestCache #55837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tvernum opened this issue Apr 28, 2020 · 2 comments · Fixed by #62534
Closed

Remove cacheKeyRenderer from IndicesRequestCache #55837

tvernum opened this issue Apr 28, 2020 · 2 comments · Fixed by #62534
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team

Comments

@tvernum
Copy link
Contributor

tvernum commented Apr 28, 2020

IndicesRequestCache has this comment:

    // NORELEASE The cacheKeyRenderer has been added in order to debug
    // https://github.com/elastic/elasticsearch/issues/32827, it should be
    // removed when this issue is solved

Since #32827 is closed, can we drop the cacheKeyRenderer argument (or remove the comment if we've decided to keep it permanently)?
@tvernum tvernum added the :Search/Search Search-related issues that do not fall into other categories label Apr 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine elasticmachine added the Team:Search Meta label for search team label Apr 28, 2020
@tvernum
Copy link
Contributor Author

tvernum commented Apr 28, 2020

Ping @jimczi since it seems you fixed the issue that this was intending to diagnose.

javanna added a commit to javanna/elasticsearch that referenced this issue Sep 17, 2020
@javanna
Remove cache key renderer argument from IndicesRequestCache
492f8bf 
In the context of of a recurring test failure tracked by elastic#32827, we added trace logging and an extra cache key renderer argument to IndicesRequestCache#getOrCompute (see elastic#39475 and elastic#34180).

We addressed the issue with elastic#54071, but the extra argument was left behind, with a NORELEASE comment saying it should be removed.

With this commit, we remove the extra cache key rendered argument and the corresponding log lines which are not so useful without it.

Closes elastic#55837
@javanna javanna mentioned this issue Sep 17, 2020
Merged
javanna added a commit that referenced this issue Sep 18, 2020
@javanna
Remove cache key renderer argument from IndicesRequestCache (#62534)
8935fff 
In the context of of a recurring test failure tracked by #32827, we added trace logging and an extra cache key renderer argument to IndicesRequestCache#getOrCompute (see #39475 and #34180).

We addressed the issue with #54071, but the extra argument was left behind, with a NORELEASE comment saying it should be removed.

With this commit, we remove the extra cache key rendered argument and the corresponding log lines which are not so useful without it.

Closes #55837
javanna added a commit to javanna/elasticsearch that referenced this issue Sep 18, 2020
@javanna
Remove cache key renderer argument from IndicesRequestCache (elastic#…
81bbb1b 
…62534)

In the context of of a recurring test failure tracked by elastic#32827, we added trace logging and an extra cache key renderer argument to IndicesRequestCache#getOrCompute (see elastic#39475 and elastic#34180).

We addressed the issue with elastic#54071, but the extra argument was left behind, with a NORELEASE comment saying it should be removed.

With this commit, we remove the extra cache key rendered argument and the corresponding log lines which are not so useful without it.

Closes elastic#55837
@javanna javanna mentioned this issue Sep 18, 2020
Merged
javanna added a commit that referenced this issue Sep 18, 2020
@javanna
Remove cache key renderer argument from IndicesRequestCache (#62534)
00272ea 
In the context of of a recurring test failure tracked by #32827, we added trace logging and an extra cache key renderer argument to IndicesRequestCache#getOrCompute (see #39475 and #34180).

We addressed the issue with #54071, but the extra argument was left behind, with a NORELEASE comment saying it should be removed.

With this commit, we remove the extra cache key rendered argument and the corresponding log lines which are not so useful without it.

Closes #55837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove cache key renderer argument from IndicesRequestCache javanna/elasticsearch
2 participants
@tvernum @elasticmachine