[CI] testRandomTimeIntervalRounding Failure

[tvernum]

Build scan: https://gradle-enterprise.elastic.co/s/plit7g4fdojhi/tests/

Repro line:

./gradlew ':server:test' \
--tests "org.elasticsearch.common.RoundingTests.testRandomTimeIntervalRounding" \
-Dtests.seed=DE09A1CC10383EB0 -Dtests.security.manager=true \
-Dtests.locale=ca-ES -Dtests.timezone=Etc/GMT+1 \
-Dcompiler.java=14 -Druntime.java=11

Reproduces locally?: No

Applicable branches: master

Failure excerpt:

Expected [148 MINUTES in America/Menominee] to \
 round [2008-11-02T07:50:16.470Z] \
    to [2008-11-02T06:56:00Z] but instead rounded \
    to [2008-11-02T07:56:00Z]
at __randomizedtesting.SeedInfo.seed([DE09A1CC10383EB0:7D4B1688B8C503D4]:0)
at org.junit.Assert.fail(Assert.java:88)
at org.elasticsearch.common.RoundingTests.testRandomTimeIntervalRounding(RoundingTests.java:410)

[elasticmachine]

Pinging @elastic/es-core-infra (:Core/Infra/Core)

[tvernum]

Ping: @nik9000 because this looks related to #56371

[rjernst]

Reproduces locally?: No

Not sure why, but this does reproduce for me.

[nik9000]

Sorry folks! I'll dig as soon as I wake up for real. Feel free to revert if it is loud.

…

On Fri, May 8, 2020, 01:42 Ryan Ernst ***@***.***> wrote: Reproduces locally?: No Not sure why, but this *does* reproduce for me. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#56400 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABUXITVXFVMQ4DTVJUSJ6LRQOLTFANCNFSM4M34C23Q> .

[elasticmachine]

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

[nik9000]

This doesn't reproduce for me, but I bet it is variable depending on the tzdb file that is in the distribution. Fun times. I was able to make some tests fail by running the random tests a ton of times. I'm going to fix those and hope that fixes this.

[nik9000]

OK! It looks like I made some assumptions about the shape of the "current transition list" vs the "future transition rules" that was incorrect. It caused duplicate transitions in my list which oddly, never broke with time unit rounding, but does break with time interval rounding. They do use different strategies, especially around overlaps. Anyway, the tzdb for America/Tijuana has a similar behavior for me locally so I can reproduce this issue. Probably.

I'll open a PR with assertions that'll trip if we hit this.

[martijnvg]

Just an fyi, another instance of this failure: https://gradle-enterprise.elastic.co/s/2ua7hql4oeqec/tests/:server:test/org.elasticsearch.common.RoundingTests/testRandomTimeIntervalRounding#1