Skip to content

JDBC driver wrong artifactId #56415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matriv opened this issue May 8, 2020 · 5 comments
Closed

JDBC driver wrong artifactId #56415

matriv opened this issue May 8, 2020 · 5 comments
Labels
:Analytics/SQL SQL querying >bug :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team Team:QL (Deprecated) Meta label for query languages team

Comments

@matriv
Copy link
Contributor

matriv commented May 8, 2020

JDBC 7.6.x poms have wrong artifact id, e.g.: https://artifacts.elastic.co/maven/org/elasticsearch/plugin/x-pack-sql-jdbc/7.6.2/x-pack-sql-jdbc-7.6.2.pom

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <modelVersion>4.0.0</modelVersion>
  <groupId>org.elasticsearch.plugin</groupId>
  <artifactId>jdbc</artifactId>
  <version>7.6.2</version>
  <inceptionYear>2009</inceptionYear>
  <licenses>
    <license>
      <name>Elastic License</name>
      <url>https://raw.githubusercontent.com/elastic/elasticsearch/v7.6.2/licenses/ELASTIC-LICENSE.txt</url>
      <distribution>repo</distribution>
    </license>
  </licenses>
  <developers>
    <developer>
      <name>Elastic</name>
      <url>http://www.elastic.co</url>
    </developer>
  </developers>
  <dependencies/>
</project>

artifactId is jdbc instead of x-pack-sql-jdbc.

Also, the 7.7.x, 7.8.0 and 8.0.0 shouldn't be there? seems they are missing.

@matriv matriv added >bug :Core/Infra/Core Core issues without another label :Analytics/SQL SQL querying labels May 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (:Query Languages/SQL)

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label May 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Core)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label May 8, 2020
@mark-vieira
Copy link
Contributor

Seems Maven doesn't care that the artifact id is incorrect, it's still able to resolve the dependency. Gradle however fails when validating the POM, so we can workaround this temporarily by telling Gradle this repository contains only artifacts, effectively making it ignore the POM. This is actually fine since these are fatjars, so the POM actually contains no useful metadata. When defining your repository in your build script, do the following:

repositories {
  maven {
    url = 'https://artifacts.elastic.co/maven'
    metadataSources {
      artifact()
    }
  }
}

@matriv matriv changed the title JDBC driver wrong artifact JDBC driver wrong artifactId May 8, 2020
@mark-vieira
Copy link
Contributor

Ok, this has been fixed now for all branches back to 7.6.

@mgreau is there way to republish broken artifacts on https://artifacts.elastic.co/maven? We have some malformed POMs up there for our JDBC client that can cause users some grief.

@matriv
Copy link
Contributor Author

matriv commented May 13, 2020

I guess it's ok to close this now @mark-vieira ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/SQL SQL querying >bug :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team Team:QL (Deprecated) Meta label for query languages team
Projects
None yet
Development

No branches or pull requests

3 participants