Always use archive base name as the pom artifact id #56447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
rjernst
approved these changes
May 8, 2020
|
|
||
| // have to defer this until archivesBaseName is set | ||
| project.afterEvaluate { | ||
| publication.artifactId = project.convention.getPlugin(BasePluginConvention).archivesBaseName |
There was a problem hiding this comment.
it's unfortunate MavenPublication doesn't use Providers :/
There was a problem hiding this comment.
My thoughts exactly.
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
May 8, 2020
mark-vieira
added a commit
that referenced
this pull request
May 8, 2020
mark-vieira
added a commit
that referenced
this pull request
May 8, 2020
mark-vieira
added a commit
that referenced
this pull request
May 8, 2020
mark-vieira
added a commit
that referenced
this pull request
May 8, 2020
mark-vieira
added
Team:Delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We override the
archivesBaseNamefor several projects. When these are published, we also interpret the GAV coordinates to use the update archive name as well. However, Gradle publishing plugins use the project name by default. We override this manually in several places but it's easy to miss some, like shadow jar projects. This PR moves this logic into ourBuildPluginso it's done in a central location and there no risk of forgetting to add the override.Relates to #56415