Skip to content

[Transform] increase page size limit to 65k #57719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hendrikmuhs opened this issue Jun 5, 2020 · 5 comments · Fixed by #74651
Closed

[Transform] increase page size limit to 65k #57719

hendrikmuhs opened this issue Jun 5, 2020 · 5 comments · Fixed by #74651
Labels
>enhancement help wanted adoptme :ml/Transform Transform

Comments

@hendrikmuhs
Copy link

#57042 increases the limit for search.max_buckets from 10k to 65k, this applies to composite aggregation, too.

Transform hard codes the old 10k limit. This should be changed to support 65k.

Ideally we remove the hard coding and read the default from the default constant, even better would be to get the value from settings, because the 65k is the default of a cluster setting.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

@RvI101
Copy link
Contributor

RvI101 commented Jun 8, 2020

I can take a look at this.

@Esduard
Copy link
Contributor

Esduard commented Jun 10, 2021

Greetings. Is this issue taken at the moment? I'd like to contribute to the project and this seems like a good issue to take.

@benwtrent
Copy link
Member

@Esduard , since the issue isn't assigned to anyone, I think its free to work on.

@Esduard Esduard mentioned this issue Jun 28, 2021
Merged
@Esduard
Copy link
Contributor

Esduard commented Jun 28, 2021

@benwtrent Thanks for letting me know. I've spent most of the time trying to run the project on my machine and have managed to run some tests after making the issue's changes.

hendrikmuhs pushed a commit that referenced this issue Jul 5, 2021
@Esduard
changing hard coded 10k page size limit to 65k (#74651)
b3e171b 
changes hard code 10k page size limit to 65k(default for `search.max_bucket`)

Closes #57719

Co-authored-by: Hendrik Muhs <[email protected]>
@hendrikmuhs hendrikmuhs mentioned this issue Jul 5, 2021
Merged
hendrikmuhs pushed a commit that referenced this issue Jul 5, 2021
[7.x][Transform] changing hard coded 10k page size limit to 65k (#74651…
3092402 
…) (#74925)

changes hard coded 10k page size limit to 65k(default for `search.max_bucket`)

Closes #57719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement help wanted adoptme :ml/Transform Transform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changing hard coded 10k page size limit to 65k
5 participants
@benwtrent @hendrikmuhs @RvI101 @elasticmachine @Esduard