Skip to content

[CI] BlobStoreRepositoryCleanupIT.testMasterFailoverDuringCleanup #69434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
martijnvg opened this issue Feb 23, 2021 · 1 comment · Fixed by #69446
Closed

[CI] BlobStoreRepositoryCleanupIT.testMasterFailoverDuringCleanup #69434

martijnvg opened this issue Feb 23, 2021 · 1 comment · Fixed by #69446
Assignees
@original-brownbear
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI

Comments

@martijnvg
Copy link
Member

Build scan: https://gradle-enterprise.elastic.co/s/hxjhopehss5ag

Repro line: ./gradlew ':server:internalClusterTest' --tests "org.elasticsearch.repositories.blobstore.BlobStoreRepositoryCleanupIT.testMasterFailoverDuringCleanup" -Dtests.seed=A5C9D3D7B6977447 -Dtests.security.manager=true -Dtests.locale=ko-KR -Dtests.timezone=EET -Druntime.java=8

Reproduces locally?: No

Applicable branches: 7.x, 7.12, 7.11

Failure history: https://build-stats.elastic.co/goto/8e9ed248199698dea8b4e63975336e8f

Failure excerpt:

  | java.lang.IllegalStateException: Cannot cleanup [test-repo] - a repository cleanup is already in-progress in [{"repository_cleanup":[{"repository":"test-repo"}]}] |  
at org.elasticsearch.action.admin.cluster.repositories.cleanup.TransportCleanupRepositoryAction$2.execute(TransportCleanupRepositoryAction.java:167) |  
  |   | at org.elasticsearch.cluster.ClusterStateUpdateTask.execute(ClusterStateUpdateTask.java:48) |  
  |   | at org.elasticsearch.cluster.service.MasterService.executeTasks(MasterService.java:691) |  
  |   | at org.elasticsearch.cluster.service.MasterService.calculateTaskOutputs(MasterService.java:313) |  
  |   | at org.elasticsearch.cluster.service.MasterService.runTasks(MasterService.java:208) |  
  |   | at org.elasticsearch.cluster.service.MasterService.access$000(MasterService.java:62) |  
  |   | at org.elasticsearch.cluster.service.MasterService$Batcher.run(MasterService.java:140) |  
  |   | at org.elasticsearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:139) |  
  |   | at org.elasticsearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:177) |  
  |   | at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:673) |  
  |   | at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedEsThreadPoolExecutor.java:241) |  
  |   | at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedEsThreadPoolExecutor.java:204) |  
  |   | at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) |  
  |   | at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) |  
  |   | at java.lang.Thread.run(Thread.java:748)
@martijnvg martijnvg added :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test-failure Triaged test failures from CI labels Feb 23, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Feb 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Feb 23, 2021
@original-brownbear
Fix BlobStoreRepositoryCleanupIT Leaking Futures
e612bd5 
The problem with elastic#69434 was that during master failover
the listener might get retried after the new master has
already dropped the cleanup from the cluster state which
then conflicts with the cleanup executed by the repo consistency
checks after each test.
To prevent running into this conflict, just wait for the future
to actually return.

Closes elastic#69434
@original-brownbear original-brownbear mentioned this issue Feb 23, 2021
Merged
original-brownbear added a commit that referenced this issue Feb 24, 2021
@original-brownbear
Fix BlobStoreRepositoryCleanupIT Leaking Futures (#69446)
9ae5f99 
The problem with #69434 was that during master failover
the listener might get retried after the new master has
already dropped the cleanup from the cluster state which
then conflicts with the cleanup executed by the repo consistency
checks after each test.
To prevent running into this conflict, just wait for the future
to actually return.

Closes #69434
@original-brownbear original-brownbear mentioned this issue Feb 24, 2021
Merged
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Feb 24, 2021
@original-brownbear
Fix BlobStoreRepositoryCleanupIT Leaking Futures (elastic#69446)
b722496 
The problem with elastic#69434 was that during master failover
the listener might get retried after the new master has
already dropped the cleanup from the cluster state which
then conflicts with the cleanup executed by the repo consistency
checks after each test.
To prevent running into this conflict, just wait for the future
to actually return.

Closes elastic#69434
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this issue Feb 24, 2021
@original-brownbear
Fix BlobStoreRepositoryCleanupIT Leaking Futures (elastic#69446)
74f48a9 
The problem with elastic#69434 was that during master failover
the listener might get retried after the new master has
already dropped the cleanup from the cluster state which
then conflicts with the cleanup executed by the repo consistency
checks after each test.
To prevent running into this conflict, just wait for the future
to actually return.

Closes elastic#69434
@original-brownbear original-brownbear mentioned this issue Feb 24, 2021
Merged
original-brownbear added a commit that referenced this issue Feb 24, 2021
@original-brownbear
Fix BlobStoreRepositoryCleanupIT Leaking Futures (#69446) (#69530)
9b17b12 
The problem with #69434 was that during master failover
the listener might get retried after the new master has
already dropped the cleanup from the cluster state which
then conflicts with the cleanup executed by the repo consistency
checks after each test.
To prevent running into this conflict, just wait for the future
to actually return.

Closes #69434
original-brownbear added a commit that referenced this issue Feb 24, 2021
@original-brownbear
Fix BlobStoreRepositoryCleanupIT Leaking Futures (#69446) (#69529)
78e0b71 
The problem with #69434 was that during master failover
the listener might get retried after the new master has
already dropped the cleanup from the cluster state which
then conflicts with the cleanup executed by the repo consistency
checks after each test.
To prevent running into this conflict, just wait for the future
to actually return.

Closes #69434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@original-brownbear original-brownbear

Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix BlobStoreRepositoryCleanupIT Leaking Futures original-brownbear/elasticsearch
3 participants
@martijnvg @original-brownbear @elasticmachine