Skip to content

Search profiler mode focused on ES queries #76430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jtibshirani opened this issue Aug 12, 2021 · 4 comments
Closed

Search profiler mode focused on ES queries #76430

jtibshirani opened this issue Aug 12, 2021 · 4 comments
Labels
>enhancement :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@jtibshirani
Copy link
Contributor

The search profiler is a really helpful tool in answering "what part of my search is slow"? But because it profiles Lucene queries, its output can be hard to understand for non-Lucene experts. For example, you might see that a PointInSetQuery or IndexOrDocValuesQuery are taking substantial time, but have no idea how this corresponds to your search request.

I wonder if we could have a profiler 'mode' that operates at the level of Elasticsearch queries. Its timings would be grouped by the queries the user actually sent, like terms or range.

Another option would be to expand the documentation on search profiling with more guidance on how to interpret the query output. This is more likely to get out-of-date though, and is still not as user-friendly. If we looked into a new profile 'mode' we could make sure to trade-off the added complexity vs. improving docs.

@jtibshirani jtibshirani added >enhancement :Search/Search Search-related issues that do not fall into other categories labels Aug 12, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Aug 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@nik9000
Copy link
Member

nik9000 commented Aug 13, 2021

Could we include the "source" of the lucene query in the profiled output so folks could attach it to some part of their request?

@javanna javanna added :Search Foundations/Search Catch all for Search Foundations and removed :Search/Search Search-related issues that do not fall into other categories labels Jul 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine elasticsearchmachine removed the Team:Search Meta label for search team label Jul 17, 2024
@javanna
Copy link
Member

javanna commented Apr 10, 2025

Closing in favour of #88370 .

@javanna javanna closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Development

No branches or pull requests

5 participants