Skip to content

Duplicated license headers #79092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joegallo opened this issue Oct 13, 2021 · 2 comments · Fixed by #79236
Closed

Duplicated license headers #79092

joegallo opened this issue Oct 13, 2021 · 2 comments · Fixed by #79236
Assignees
Labels
>bug :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team

Comments

@joegallo
Copy link
Contributor

joegallo commented Oct 13, 2021

I ran into this over on https://github.com/elastic/elasticsearch/blob/eb22aa1060f065f3403be0532075badc6e44c6f9/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/cluster/action/MigrateToDataTiersAction.java -- there's two (differing) license headers in that one file.

Here's a unix-y incantation to find more of them (not necessarily all of them, and I haven't checked the result for false positives, but it's a good starting off point):

joegallo@galactic:~/Code/elastic/elasticsearch $ git grep 'Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one' | sort | grep java: | cut -d: -f1 | uniq -d
server/src/internalClusterTest/java/org/elasticsearch/search/geo/GeoPointScriptDocValuesIT.java
server/src/main/java/org/elasticsearch/rest/RestCompatibleVersionHelper.java
server/src/main/java/org/elasticsearch/shutdown/PluginShutdownService.java
server/src/main/java/org/elasticsearch/usage/UsageService.java
x-pack/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/allocation/CcrPrimaryFollowerAllocationDecider.java
x-pack/plugin/ccr/src/test/java/org/elasticsearch/xpack/ccr/allocation/CcrPrimaryFollowerAllocationDeciderTests.java
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/cluster/action/MigrateToDataTiersAction.java
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/accesscontrol/MatchAllRoleBitSet.java
x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/BaseSearchableSnapshotsIntegTestCase.java
x-pack/plugin/searchable-snapshots/src/internalClusterTest/java/org/elasticsearch/xpack/searchablesnapshots/SearchableSnapshotsLicenseIntegTests.java
x-pack/plugin/spatial/src/internalClusterTest/java/org/elasticsearch/xpack/spatial/search/GeoShapeScriptDocValuesIT.java
x-pack/plugin/spatial/src/internalClusterTest/java/org/elasticsearch/xpack/spatial/search/GeoShapeWithDocValuesQueryTests.java
x-pack/plugin/spatial/src/test/java/org/elasticsearch/xpack/spatial/index/mapper/GeoShapeWithDocValuesFieldMapperTests.java
x-pack/plugin/spatial/src/yamlRestTest/java/org/elasticsearch/xpack/spatial/SpatialClientYamlTestSuiteIT.java
x-pack/plugin/vector-tile/src/yamlRestTest/java/org/elasticsearch/xpack/vectortile/VectorTileClientYamlTestSuiteIT.java

Ideally our license checking infrastructure should reject these -- just fixing them one off isn't awesome because clearly this is a thing that sneaks in sometimes.

/cc @mark-vieira

@joegallo joegallo added >bug :Delivery/Build Build or test infrastructure needs:triage Requires assignment of a team area label labels Oct 13, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Oct 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby
Copy link
Contributor

thanks for reporting. looking into this

@breskeby breskeby self-assigned this Oct 14, 2021
breskeby added a commit to breskeby/elasticsearch that referenced this issue Oct 15, 2021
This fixes elastic#79092.

A follow up on tighten our licenseheader checks was raised at elastic#79235 and will be
addressed in a separate PR
@DJRickyB DJRickyB removed the needs:triage Requires assignment of a team area label label Oct 15, 2021
breskeby added a commit that referenced this issue Oct 18, 2021
This fixes #79092.

A follow up on tighten our licenseheader checks was raised at #79235 and will be
addressed in a separate PR
breskeby added a commit that referenced this issue Oct 18, 2021
This fixes #79092.

A follow up on tighten our licenseheader checks was raised at #79235 and will be
addressed in a separate PR
# Conflicts:
#	x-pack/plugin/mapper-unsigned-long/src/yamlRestTest/java/org/elasticsearch/xpack/unsignedlong/UnsignedLongClientYamlTestSuiteIT.java
elasticsearchmachine pushed a commit that referenced this issue Oct 18, 2021
This fixes #79092.

A follow up on tighten our licenseheader checks was raised at #79235 and will be
addressed in a separate PR
# Conflicts:
#	x-pack/plugin/mapper-unsigned-long/src/yamlRestTest/java/org/elasticsearch/xpack/unsignedlong/UnsignedLongClientYamlTestSuiteIT.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants