Spotless removes space before instanceof in pattern match

[DaveCTurner]

Spotless does this:

diff --git a/server/src/main/java/org/elasticsearch/cluster/coordination/Publication.java b/server/src/main/java/org/elasticsearch/cluster/coordination/Publication.java
index 3a48bb3f05d..506c0efe8ac 100644
--- a/server/src/main/java/org/elasticsearch/cluster/coordination/Publication.java
+++ b/server/src/main/java/org/elasticsearch/cluster/coordination/Publication.java
@@ -378,7 +378,7 @@ public abstract class Publication {

         private Exception getRootCause(Exception e) {
             if (e instanceof final TransportException transportException) {
-                if (transportException.getRootCause() instanceof final Exception rootCause) {
+                if (transportException.getRootCause()instanceof final Exception rootCause) {
                     return rootCause;
                 } else {
                     assert false : e;

An aesthetic thing for sure but I think it's better with the space than without.

[elasticmachine]

Pinging @elastic/es-delivery (Team:Delivery)

[mark-vieira]

This looks to be a bug in eclipse-jdt. There's no explicit formatter setting for instanceof pattern matching, it's just the formatter not understanding this syntax. Eclipse version 2021.12, using eclipse-jdt 4.22 works as intended. We unfortunately have to wait for a) the IntelliJ plugin to update the bundled Eclipse libraries and b) Spotless to update eclipse-jdt to 4.22.

I was able to get the IDE to work as intended by configuring the IntelliJ Eclipse Formatter plugin to point to an Eclipse 2021.12 installation, so that at least confirms that version of eclipse-jdt works as intended. That said, we need both IDE and CLI to match otherwise folks will reformat in IntelliJ and spotless with complain or vice versa.

We can open a PR for spotless for this but the IntelliJ plugin doesn't seem to use any kind of dependency management. I suspect the author has to download the updated libraries locally and rebuild.

[mark-vieira]

We aren't the only ones asking for this: diffplug/spotless#1059

[mark-vieira]

An aesthetic thing for sure but I think it's better with the space than without.

This definitely triggers me as well.

[pugnascotia]

Spotless has finally updated, so we should now be able to address this issue.