Skip to content

Multiple Data Paths deprecation is marked as Critical rather than warning #85695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rdnm opened this issue Apr 5, 2022 · 3 comments
Closed

Multiple Data Paths deprecation is marked as Critical rather than warning #85695

rdnm opened this issue Apr 5, 2022 · 3 comments
Assignees
@rjernst
Labels
>bug :Core/Infra/Settings Settings infrastructure and APIs Team:Core/Infra Meta label for core/infra team

Comments

@rdnm
Copy link

rdnm commented Apr 5, 2022

Elasticsearch Version

7.17

Installed Plugins

No response

Java Version

bundled

OS Version

Any

Problem Description

In the upgrade assistant in 7.17 a critical warning is shown saying "Multiple data paths are not supported". This should be downgraded to a warning, as Multiple Data Paths were not removed in 8.0, and thus this should not stop upgrade to 8.0.

See #71205 (comment) for more details.

Steps to Reproduce

Create an elasticsearch deployment with multiple data paths configured. Run the upgrade assistant in 7.17. You will see there is a Critical deprecation message for the multiple data paths feature.

Logs (if relevant)

No response
@rdnm rdnm added >bug needs:triage Requires assignment of a team area label Team:Core/Infra Meta label for core/infra team labels Apr 5, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@grcevski grcevski self-assigned this Apr 5, 2022
@DJRickyB DJRickyB added :Core/Infra/Settings Settings infrastructure and APIs and removed needs:triage Requires assignment of a team area label labels Apr 5, 2022
@willemdh willemdh mentioned this issue Apr 6, 2022
Open
5 tasks
@rjernst rjernst assigned rjernst and unassigned grcevski Apr 13, 2022
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 18, 2022
@rjernst
Relax data path deprecations from critical to warn
71354f8 
The deprecations for index and shared data paths were defined at
critical level, but these are not removed in 8.0. This commit relaxes
these deprecation messages so they are just warnings.

relates elastic#85695
@rjernst rjernst mentioned this issue Apr 18, 2022
Merged
@rjernst
Copy link
Member

rjernst commented Apr 18, 2022

I haven't been able to find this particular deprecation message in Elasticsearch, is it possible it is coming from Kibana directly?

I did find a couple critical deprecations related to this, which I've adjusted in #85952.

Note that the deprecation log had MDP as critical earlier in 7.x but that was fixed in #79463 for 7.16.

rjernst added a commit that referenced this issue Apr 18, 2022
@rjernst
Relax data path deprecations from critical to warn (#85952)
c52ff05 
The deprecations for index and shared data paths were defined at
critical level, but these are not removed in 8.0. This commit relaxes
these deprecation messages so they are just warnings.

relates #85695
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 18, 2022
@rjernst
Relax data path deprecations from critical to warn (elastic#85952)
d3246b6 
The deprecations for index and shared data paths were defined at
critical level, but these are not removed in 8.0. This commit relaxes
these deprecation messages so they are just warnings.

relates elastic#85695
elasticsearchmachine pushed a commit that referenced this issue Apr 18, 2022
@rjernst
Relax data path deprecations from critical to warn (#85952) (#85963)
b847e5d 
The deprecations for index and shared data paths were defined at
critical level, but these are not removed in 8.0. This commit relaxes
these deprecation messages so they are just warnings.

relates #85695
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 19, 2022
@rjernst
Relax data path deprecations from critical to warn (elastic#85952)
b759f98 
The deprecations for index and shared data paths were defined at
critical level, but these are not removed in 8.0. This commit relaxes
these deprecation messages so they are just warnings.

relates elastic#85695
@rjernst rjernst mentioned this issue Apr 19, 2022
Merged
elasticsearchmachine pushed a commit that referenced this issue Apr 20, 2022
@rjernst
Relax data path deprecations from critical to warn (#85952) (#85976)
27ad7e1 
* Relax data path deprecations from critical to warn (#85952)

The deprecations for index and shared data paths were defined at
critical level, but these are not removed in 8.0. This commit relaxes
these deprecation messages so they are just warnings.

relates #85695

* tweak test

* casing...
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 22, 2022
@rjernst
Adjust MDP deprecation to warning instead of critical
08d92a1 
Multiple data paths was deprecated in 7.13, but the deprecation notice
in the deprecation api was set to critical, even though it is not
removed in 8.0. This commit adjusts the deprecation level to warning.

closes elastic#85695
@rjernst rjernst mentioned this issue Apr 22, 2022
Merged
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 22, 2022
@rjernst
Forward port MDP deprecation info api
c69c3e4 
Multiple data paths was deprecated in 7.13. At the time, the deprecation
was only added to the deprecation logs. Later, it was also added to the
deprecation info api, but by that time, MDP had already been removed
from master. When MDP was added back to master, the deprecation log
messages were added back, but the info api messages were not since they
never existed in master.

This commit forward ports the deprecation info messages for MDP to 8.x.

relates elastic#85695
@rjernst rjernst mentioned this issue Apr 22, 2022
Merged
rjernst added a commit that referenced this issue Apr 25, 2022
@rjernst
Forward port MDP deprecation info api (#86103)
108a54f 
Multiple data paths was deprecated in 7.13. At the time, the deprecation
was only added to the deprecation logs. Later, it was also added to the
deprecation info api, but by that time, MDP had already been removed
from master. When MDP was added back to master, the deprecation log
messages were added back, but the info api messages were not since they
never existed in master.

This commit forward ports the deprecation info messages for MDP to 8.x.

relates #85695
rjernst added a commit that referenced this issue Apr 25, 2022
@rjernst
Adjust MDP deprecation to warning instead of critical (#86102)
9024401 
Multiple data paths was deprecated in 7.13, but the deprecation notice
in the deprecation api was set to critical, even though it is not
removed in 8.0. This commit adjusts the deprecation level to warning.

closes #85695
rjernst added a commit to rjernst/elasticsearch that referenced this issue Apr 25, 2022
@rjernst
Forward port MDP deprecation info api (elastic#86103)
50061ec 
Multiple data paths was deprecated in 7.13. At the time, the deprecation
was only added to the deprecation logs. Later, it was also added to the
deprecation info api, but by that time, MDP had already been removed
from master. When MDP was added back to master, the deprecation log
messages were added back, but the info api messages were not since they
never existed in master.

This commit forward ports the deprecation info messages for MDP to 8.x.

relates elastic#85695
elasticsearchmachine pushed a commit that referenced this issue Apr 25, 2022
@rjernst
Forward port MDP deprecation info api (#86103) (#86147)
2149ead 
Multiple data paths was deprecated in 7.13. At the time, the deprecation
was only added to the deprecation logs. Later, it was also added to the
deprecation info api, but by that time, MDP had already been removed
from master. When MDP was added back to master, the deprecation log
messages were added back, but the info api messages were not since they
never existed in master.

This commit forward ports the deprecation info messages for MDP to 8.x.

relates #85695
@rjernst
Copy link
Member

rjernst commented May 23, 2022

This was fixed in #86102

@rjernst rjernst closed this as completed May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjernst rjernst

Labels
>bug :Core/Infra/Settings Settings infrastructure and APIs Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rjernst @grcevski @DJRickyB @elasticmachine @rdnm