Add node id to _cat apis #10246
Closed
Add node id to _cat apis #10246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
new CLA? |
| type .+ \n | ||
| url .+ \n | ||
| description .+ \n | ||
| $/ |
| @@ -77,6 +77,7 @@ public RestResponse buildResponse(final NodesInfoResponse nodesInfoResponse) thr | |||
| Table getTableWithHeader(final RestRequest request) { | |||
| Table table = new Table(); | |||
| table.startHeaders(); | |||
| table.addCell("id", "alias:i;default:false;desc:unique node id"); | |||
There was a problem hiding this comment.
maybe we want to drop the i alias here and be consistent with the other cat apis? id seems short enough already no?
|
looks good @lmenezes I left a small comment, if you can address that I will get this in. |
|
@javanna done. if you want me to rebase and squash it, let me know :) |
|
Thanks @lmenezes merged! |
|
@javanna great, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this addresses #10226 and also adds node id to _cat/segments and _cat/plugins.
/cc @drewr @javanna