Skip to content

Collapse all transport versions between 8.11 and 8.12 into a constant for 8.12 #104937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Jan 30, 2024

Collapse all transport versions between 8.11.0 and 8.12.0 into a single constant

@thecoop thecoop marked this pull request as ready for review February 6, 2024 15:37
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Feb 6, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop
Copy link
Member Author

thecoop commented Feb 7, 2024

@maxhniebergall This gets rid of the version mess with ELSER model serialization - could you check the simplified logic is correct, and if there's anywhere else that needs to be changed?

Copy link
Contributor

@maxhniebergall maxhniebergall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think there are any other places that need to be changed. Thanks!

@thecoop
Copy link
Member Author

thecoop commented Feb 7, 2024

@elasticmachine update branch

@thecoop thecoop merged commit 9ba5651 into elastic:main Feb 8, 2024
@thecoop thecoop deleted the collapse-8.12-tvs branch February 8, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants