Skip to content

apm-data: set concrete values for metricset.interval #109043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

endorama
Copy link
Member

@endorama endorama commented May 24, 2024

While testing the upgrade path from 8.14 to 8.15 I noticed an unexpected mapping error.

This PR aims at solving it by adding a concrete value to metricset.interval mappings as suggested here.

Upon testing the upgrade path again the mentioned error did not present themselves anymore.

@endorama endorama requested a review from a team as a code owner May 24, 2024 20:10
@elasticsearchmachine elasticsearchmachine added v8.15.0 needs:triage Requires assignment of a team area label labels May 24, 2024
@axw axw added >bug :Data Management/Data streams Data streams and their lifecycles labels May 27, 2024
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added Team:Data Management Meta label for data/management team and removed needs:triage Requires assignment of a team area label labels May 27, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @endorama, I've created a changelog YAML for you.

@axw axw added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label May 27, 2024
@elasticsearchmachine elasticsearchmachine merged commit 01fdeca into elastic:main May 27, 2024
15 checks passed
@endorama endorama deleted the apmdata-constant_keyword-mapping-value branch May 27, 2024 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants