Skip to content

REST spec for termvector missing paths on 1.x branch #11087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

REST spec for termvector missing paths on 1.x branch #11087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions rest-api-spec/api/termvector.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"documentation" : "http://www.elastic.co/guide/en/elasticsearch/reference/1.x/docs-termvectors.html",
"methods" : ["GET", "POST"],
"url" : {
"path" : "/{index}/{type}/{id}/_termvector",
"paths" : ["/{index}/{type}/{id}/_termvector"],
"path" : "/{index}/{type}/_termvector",
"paths" : ["/{index}/{type}/_termvector", "/{index}/{type}/{id}/_termvector"],
"parts" : {
"index" : {
"type" : "string",
Expand All @@ -18,8 +18,7 @@
},
"id" : {
"type" : "string",
"description" : "The id of the document.",
"required" : true
"description" : "The id of the document."
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe here "required" : false

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/elastic/elasticsearch/blob/master/rest-api-spec/api/bulk.json others just leave required out for parts where its false too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK sounds good.

},
"params": {
Expand Down