Fix exception message when validating the name of tokenizer(edgeNGram) #112705
Conversation
elasticsearchmachine
added
needs:triage
YeonghyeonKO
changed the title
|
@mark-vieira Hi,
|
javanna
added
:Search Relevance/Analysis
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
As mentioned in the licensing FAQ the AGPL change will apply starting with version 8.16. |
carlosdelest
added
auto-backport
|
@elasticsearchmachine run elasticsearch-ci |
|
@elasticsearchmachine update branch |
|
@elasticmachine test this please |
|
@YeonghyeonKO I tried to update the branch and resolve conflicts, but some compilation errors resulted from it. Can you please update from the branch and correct them? Thanks! |
|
@carlosdelest @YeonghyeonKO take a look here: #113009 |
|
@carlosdelest Thanks for pulling codes from main branch to this branch. I fixed compilation error by importing classes and defining static variable(deprecationLogger). However as @benwtrent commented above that after @javanna's PR( #113009 ) had been merged already, this PR can be CLOSED. |
| @@ -296,6 +303,22 @@ public Map<String, AnalysisProvider<TokenizerFactory>> getTokenizers() { | |||
| tokenizers.put("thai", ThaiTokenizerFactory::new); | |||
| tokenizers.put("ngram", NGramTokenizerFactory::new); | |||
| tokenizers.put("edge_ngram", EdgeNGramTokenizerFactory::new); | |||
| tokenizers.put("edgeNGram", (IndexSettings indexSettings, Environment environment, String name, Settings settings) -> { | |||
There was a problem hiding this comment.
yeah, this should just be removed :). I think this pr can be closed.
There was a problem hiding this comment.
Ok, thanks for reviewing my PR :)
|
This fix was still valid for 8.x I believe, my commit with the removal went only to main. |
|
Thanks for clarifying @javanna ! @YeonghyeonKO , can you open another PR with this code, but to 8.x branch, and assign it to me? Thanks! |
|
@carlosdelest @javanna |
The method
getTokenizersinCommonAnalysisPluginreturns IllegalArgumentException with the message:After IndexVersion v.8.0.0,
edge_ngram(notedge_nGram) is the exact name of edgeNGram tokenizer so I ask to change the word in this Pull Request. The PR could reduce confusion in defining edgeNGram tokenizers when statically mapping indices in Elasticsearch.