Fix needsScore computation in GlobalOrdCardinalityAggregator #113129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @iverase, I've created a changelog YAML for you. |
nik9000
approved these changes
Sep 30, 2024
.../main/java/org/elasticsearch/search/aggregations/metrics/GlobalOrdCardinalityAggregator.java
Show resolved
Hide resolved
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Oct 1, 2024
…#113129) Only use TOP_DOCS if we are going to use dynamic pruning.
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Oct 1, 2024
…#113129) Only use TOP_DOCS if we are going to use dynamic pruning.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 1, 2024
#113833) Only use TOP_DOCS if we are going to use dynamic pruning.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 1, 2024
#113832) Only use TOP_DOCS if we are going to use dynamic pruning.
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 4, 2024
…#113129) Only use TOP_DOCS if we are going to use dynamic pruning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding dynamic pruning for GlobalOrdCardinalityAggregator, it was introduced a bug on how we compute needsScore as it does not take into account if the cardinality has parent, so in that cases it might return the wrong answer. This commit fixes that.
fixes #112975