Skip to content

Make xpack.otel_data.registry.enabled default to true #113468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ public abstract class AbstractDataStreamIT extends ESRestTestCase {
// Disable apm-data so the index templates it installs do not impact
// tests such as testIgnoreDynamicBeyondLimit.
.setting("xpack.apm_data.enabled", "false")
.setting("xpack.otel_data.registry.enabled", "false")
.build();
protected RestClient client;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public class LogsIndexModeCustomSettingsIT extends LogsIndexModeRestTestIT {
.module("x-pack-aggregate-metric")
.module("x-pack-stack")
.setting("xpack.security.enabled", "false")
.setting("xpack.otel_data.registry.enabled", "false")
.setting("xpack.license.self_generated.type", "trial")
.setting("cluster.logsdb.enabled", "true")
.build();
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugin/ml/qa/native-multi-node-tests/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ testClusters.configureEach {
setting 'stack.templates.enabled', 'false'
setting 'xpack.ent_search.enabled', 'false'
setting 'xpack.apm_data.enabled', 'false'
setting 'xpack.otel_data.registry.enabled', 'false'
// To spice things up a bit, one of the nodes is not an ML node
nodes.'javaRestTest-0'.setting 'node.roles', '["master","data","ingest"]'
nodes.'javaRestTest-1'.setting 'node.roles', '["master","data","ingest","ml"]'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ public class OTelPlugin extends Plugin implements ActionPlugin {
// This setting will be ignored if the plugin is disabled.
static final Setting<Boolean> OTEL_DATA_REGISTRY_ENABLED = Setting.boolSetting(
"xpack.otel_data.registry.enabled",
// OTel-data is under development, and we start with opt-in first.
// Furthermore, this could help with staged rollout in serverless
false,
true,
Setting.Property.NodeScope,
Setting.Property.Dynamic
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ public class OTelYamlTestSuiteIT extends ESClientYamlSuiteTestCase {
.module("x-pack-stack")
.module("mapper-version")
.setting("ingest.geoip.downloader.enabled", "false")
.setting("xpack.otel_data.registry.enabled", "true")
.build();

public OTelYamlTestSuiteIT(@Name("yaml") ClientYamlTestCandidate testCandidate) {
Expand Down