Skip to content

[8.x] Remove match command (#113383) #113525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2024
Merged

[8.x] Remove match command (#113383) #113525

merged 3 commits into from
Sep 26, 2024

Conversation

ioanatia
Copy link
Contributor

Backports the following commits to 8.x:

@ioanatia
Remove match command (elastic#113383)
d08faeb 
* Remove match command

* Remove assertMatchCommand

* Remove unused import
@ioanatia ioanatia requested a review from a team as a code owner September 25, 2024 11:22
@ioanatia ioanatia added :Analytics/ES|QL AKA ESQL >non-issue backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) test-release Trigger CI checks against release build labels Sep 25, 2024
@elasticsearchmachine elasticsearchmachine mentioned this pull request Sep 25, 2024
Merged
@ioanatia
Copy link
Contributor Author

@elasticmachine merge upstream

@ioanatia
Copy link
Contributor Author

@elasticmachine merge upstream

@ioanatia
Copy link
Contributor Author

I merged upstream thinking some of the failures have been solved in the meantime.
Looking at the failures they are unrelated to the changes - I also see some of these changes happening in other PRs.
None of them are ES|QL related.
Leaving this PR open has the potential of making it difficult to merge any other backports that touch the lexer/parser due to conflicts.
I am not a fan of merging by bypassing branch protections, but I will do that in this case.

@ioanatia ioanatia merged commit c64c1fb into elastic:8.x Sep 26, 2024
12 of 17 checks passed
@ioanatia ioanatia deleted the backport/8.x/pr-113383 branch September 26, 2024 11:41
This was referenced Sep 26, 2024
Closed
Merged
@DaveCTurner
Copy link
Contributor

Hi @ioanatia, please don't merge things without a clean CI run. Just because it's hitting failures that appear to be unrelated doesn't mean that there aren't other failures later on in the build that are related to this change. We can get into a massive mess if that starts to happen.

Please instead either wait for the problems to be resolved (ping the relevant folks if needed) or else mute the problematic tests yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL backport >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) test-release Trigger CI checks against release build v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ioanatia @DaveCTurner @elasticsearchmachine @elasticmachine