Fix testWatchdogLogging
#113758
Merged
Fix testWatchdogLogging
#113758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that the expected thread isn't the only thread that made no progress since the last check, so this commit generalizes the assertion to allow for other threads to be mentioned here too. Closes elastic#113734
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
idegtiarenko
approved these changes
Sep 30, 2024
DaveCTurner
added
auto-merge-without-approval
|
All the checks succeeded AFAICT, it's just that Github didn't get the message. |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 1, 2024
It's possible that the expected thread isn't the only thread that made no progress since the last check, so this commit generalizes the assertion to allow for other threads to be mentioned here too. Closes elastic#113734
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 1, 2024
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 4, 2024
It's possible that the expected thread isn't the only thread that made no progress since the last check, so this commit generalizes the assertion to allow for other threads to be mentioned here too. Closes elastic#113734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that the expected thread isn't the only thread that made
no progress since the last check, so this commit generalizes the
assertion to allow for other threads to be mentioned here too.
Closes #113734