Reapply "synthetic source index setting provider should check source field mapper" #113759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
force-pushed
the
get_113522_back_in
branch
from
6c19be7 to
b2f1541
Compare
…field mapper (elastic#113522)" (elastic#113745) This reverts commit e0a2d61.
martijnvg
force-pushed
the
get_113522_back_in
branch
from
b2f1541 to
60ae0ca
Compare
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Oct 1, 2024
…field mapper" (elastic#113759) Originally added via elastic#113522, but then reverted via elastic#113745, because of mixed cluster test failures (elastic#113730). This PR is a clean revert of the commit the reverted elastic#113522 and one additional commit that should address the build failures report in elastic#113730 : c7bd242 Basically create index invocation that would fail anyway should be ignored. If mapper service creation now fails, then we just assume that there is no synthetic source usage. This is ok, because the index creation would fail anyway later one. Closes elastic#113730
martijnvg
added a commit
that referenced
this pull request
Oct 1, 2024
…ource field mapper" (#113759) (#113828) Backporting #113759 to 8.x branch. Originally added via #113522, but then reverted via #113745, because of mixed cluster test failures (#113730). This PR is a clean revert of the commit the reverted #113522 and one additional commit that should address the build failures report in #113730 : c7bd242 Basically create index invocation that would fail anyway should be ignored. If mapper service creation now fails, then we just assume that there is no synthetic source usage. This is ok, because the index creation would fail anyway later one. Closes #113730
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 4, 2024
…field mapper" (elastic#113759) Originally added via elastic#113522, but then reverted via elastic#113745, because of mixed cluster test failures (elastic#113730). This PR is a clean revert of the commit the reverted elastic#113522 and one additional commit that should address the build failures report in elastic#113730 : c7bd242 Basically create index invocation that would fail anyway should be ignored. If mapper service creation now fails, then we just assume that there is no synthetic source usage. This is ok, because the index creation would fail anyway later one. Closes elastic#113730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally added via #113522, but then reverted via #113745, because of mixed cluster test failures (#113730).
This PR is a clean revert of the commit the reverted #113522 and one additional commit that should address the build failures report in #113730 : c7bd242
Basically create index invocation that would fail anyway should be ignored. If mapper service creation now fails, then we just assume that there is no synthetic source usage. This is ok, because the index creation would fail anyway later one.
Closes #113730