Add JIT compiler directives to workaround performance regression in memory segment access in JDK 23 #113817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHegarty
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ChrisHegarty
added a commit
that referenced
this pull request
Oct 1, 2024
…emory segment access in JDK 23 (#113817) This commit adds a couple of JIT compiler directives to avoid a performance pitfall in JDK 23. Ultimately this is a workaround for a JDK 23 bug, which has been reported and will be fixed in a future version of the JDK. The nested rally track uncovered the JDK performance regression. Running JDK 23 with the compiler directives in this PR restores performance, and in fact improves it in several cases.
matthewabbott
pushed a commit
to matthewabbott/elasticsearch
that referenced
this pull request
Oct 4, 2024
…emory segment access in JDK 23 (elastic#113817) This commit adds a couple of JIT compiler directives to avoid a performance pitfall in JDK 23. Ultimately this is a workaround for a JDK 23 bug, which has been reported and will be fixed in a future version of the JDK. The nested rally track uncovered the JDK performance regression. Running JDK 23 with the compiler directives in this PR restores performance, and in fact improves it in several cases.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 15, 2024
After completing additional validation with the JIT workaround in elastic#113817, this commit upgrades the bundled JDK to 23.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 15, 2024
After completing additional validation with the JIT workaround in elastic#113817, this commit upgrades the bundled JDK to 23. This is a backport of elastic#114823
rjernst
added a commit
that referenced
this pull request
Oct 22, 2024
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 22, 2024
After completing additional validation with the JIT workaround in elastic#113817, this commit upgrades the bundled JDK to 23. This is a backport of elastic#114823
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 24, 2024
rjernst
added a commit
that referenced
this pull request
Oct 30, 2024
After completing additional validation with the JIT workaround in #113817, this commit upgrades the bundled JDK to 23.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
After completing additional validation with the JIT workaround in elastic#113817, this commit upgrades the bundled JDK to 23.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a couple of JIT compiler directives to avoid a performance pitfall in JDK 23.
Ultimately this is a workaround for a JDK 23 bug [1], which has been reported and will be fixed in a future version of the JDK.
The nested rally track uncovered the JDK performance regression. Running JDK 23 with the compiler directives in this PR restores performance, and in fact improves it in several cases.
closes #113030
[1] https://bugs.openjdk.org/browse/JDK-8341127